Bug 364492

Summary: Upgrade from 5.6: if existing launchers are there, moving around icons deletes them
Product: [Plasma] plasmashell Reporter: Christian (Fuchs) <kde>
Component: Icons-only Task ManagerAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: normal CC: plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.5.95   
Target Milestone: 1.0   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: http://commits.kde.org/plasma-workspace/bfbf06ef8f3c6a135e4765b691696a10ad22ea84 Version Fixed/Implemented In:
Sentry Crash Report:

Description Christian (Fuchs) 2016-06-19 10:13:00 UTC 
I upgraded from 5.6 to 5.7 beta with icon only task manager and existing launchers. 
When moving around icons, these launchers got removed. 

Removing and re-adding a fresh icon tasks resolved this, but of course it would be nice if 5.6 settings would be properly taken over

Reproducible: Always

Steps to Reproduce:
1. Use Icon only taskmanager
2. Create some launchers
3. Upgrade from 5.6 to 5.7, grab a launcher and drag it around

Actual Results:  
Other launchers get removed

Expected Results:  
Launchers are kept
Comment 1 Eike Hein 2016-06-20 03:34:01 UTC 
Do you still have a copy of your old config by any chance? Did the launchers initially get added correctly?
Comment 2 Eike Hein 2016-06-20 08:30:51 UTC 
Git commit bfbf06ef8f3c6a135e4765b691696a10ad22ea84 by Eike Hein.
Committed on 20/06/2016 at 08:30.
Pushed by hein into branch 'Plasma/5.7'.

Fix launchers getting lost on DND resorts when using 5.6-style config.

This is an unfortunate regression that crept in via 7eff45a98f4e5 the
just the other day: Legacy config can have query items other than
iconData in launcher URLs, which also need to be stripped before doing
the equivalence test matching up launcher-backed window tasks with
launcher URLs. Back to venerable launcherUrlsMatch() as originally --
the real speed optimization is in fetching the right role, anyway, and
as it turns out we really can't save that one call to adjusted() as it
was necessary.

M  +1    -2    libtaskmanager/tasksmodel.cpp

http://commits.kde.org/plasma-workspace/bfbf06ef8f3c6a135e4765b691696a10ad22ea84