Bug 364369

Summary: git master 2016-06-15 - Save/load/revert improvements.
Product: [Applications] kdenlive Reporter: Evert Vorster <evorster>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Evert Vorster 2016-06-16 07:25:03 UTC 
There is some easy bits of polish to be added here, which your kdenlive users will be very, very pleased. 

1. When hitting "revert", check whether the project modified flag has been set. If not, don't pop up the error message about saving your work, the work IS saved. 

2. Versioned saves. 
Do every file save as a new version, so that previous versions of the file is still available. As a bonus, a "delete previous saved versions" button could be added. A user would hit this if he/she is happy that the currently restored video is correct, and previous versions is not needed. 

What this will do for your users is that when a file is saved, the previous version is not destroyed. It seems that we are sometimes getting corruptions on file saves, and this is one way of lessening the impact of such corruptions. 

Reproducible: Always
Comment 1 Evert Vorster 2016-06-16 07:28:02 UTC 
Hmm... it could be an idea to save in a zipped format, and each version is saved as a separate file inside that zip, or tarball or whatever. The save file will grow with every save, but then deleting the previous versions will be easy. 
With this approach, the directory that the projects are saved in is not polluted with loads of little files, which can be a pain. I delete .backup files often for exactly this reason.
Comment 2 Jean-Baptiste Mardelle 2016-06-16 16:51:16 UTC 
1. Ok, will do
2. Already done unless I misunderstood. Kdenlive keeps a hidden copy of each saved version (and deletes the older ones). You can access them from Project > Open Backup File. Is that what you wanted?
Comment 3 Jean-Baptiste Mardelle 2016-06-16 16:55:33 UTC 
Git commit a8f6fe514001093df89d506c09ac3aef3c936736 by Jean-Baptiste Mardelle.
Committed on 16/06/2016 at 16:54.
Pushed by mardelle into branch 'master'.

Don't warn on lost changes if project was not modified

M  +1    -1    src/project/projectmanager.cpp

http://commits.kde.org/kdenlive/a8f6fe514001093df89d506c09ac3aef3c936736
Comment 4 Evert Vorster 2016-06-16 17:38:37 UTC 
Hi there. 

I was not even aware of that feature. I would have started looking around the save and load buttons, or maybe in the load recent menu if you did not tell me where it was. 

For some reason, I have backups all the way back to the creation of this project, so the old versions have not been deleted. This is a good thing, and exactly what I was asking for. 

I am curious, though, how are the files hidden?
Comment 5 Jean-Baptiste Mardelle 2016-06-16 17:43:51 UTC 
That feature was implemented a long time ago, I had to double check, and in fact it saves all backup files in a hidden folder $HOME/.backup That should probably be changed to a more XDG compliant place...
Comment 6 Jean-Baptiste Mardelle 2016-06-16 17:44:19 UTC 
Err, I meant $HOME/kdenlive/.backup
Comment 7 Evert Vorster 2016-06-25 05:39:13 UTC 
Yes, this is actually perfect.