Bug 364367

Summary: git master 2016-06-16 - Speed effect causes corruption in saved files
Product: [Applications] kdenlive Reporter: Evert Vorster <evorster>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: A saved file that was opened with the corruption

Description Evert Vorster 2016-06-16 07:17:51 UTC 
Add the speed effect and speeding up clips in particular has some strange effects on saved files. 

Reproducible: Sometimes

Steps to Reproduce:
1.Put a long clip on the timeline
2.Apply speed effect, 1000% is good. :)
3.Put another clip in contact just after the clip with the speed effect applied. 
4. For bonus fun, have a bunch of groups of clips behind these
5. Save your project
6. Load it. 

Actual Results:  
Sometimes, almost all the time, the clips behind the speed effect is corrupted somehow. 
I believe this is due to the real length of the clip being read and applied to the timeline during either the saving or loading process. 

Expected Results:  
Project to look exactly like it did when it was saved. 

I think that there is an issue at the bottom of the timeline corruptions that I can see. 
Assuming that there is no overlaps on the timeline is one thing, but then this must be enforced during save and load. 
It might be an idea to add the clip, then it's effects, then the next clip from left to right, and so on during a restore. Disabling user input while the timeline is being populated might be a good idea. It would actually be a cool "progress indicator" to watch the timeline fill up when doing a load of a project.
Comment 1 Evert Vorster 2016-06-16 17:46:13 UTC 
Created attachment 99535 [details]
A saved file that was opened with the corruption

With the backup feature, I was able to scroll back to the first file that showed the corruption. 

Here it is, in all it's glory. Around the middle is where the clip with the 10x speedup was inserted, and all the video parts of the clips that had video on the same track had been deleted. 

I don't know whether the file was corrupted on the save, or on the load, but I assure you that it was fine when I saved it before, with no sign of corruption.
Comment 2 Evert Vorster 2016-08-09 07:26:07 UTC 
This issue seems fixed now. 

Thanks