Bug 364333

Summary: Random resets of several configuration values
Product: [Applications] digikam Reporter: Victor Engmark <kde.org>
Component: Plugin-RawImport-NativeAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 4.14.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.0.0
Sentry Crash Report:

Description Victor Engmark 2016-06-14 22:16:45 UTC 
I keep Arch Linux up to date at all times with the latest packages. I also version control ~/.kde4/share/config/digikamrc. 

Reproducible: Always

Steps to Reproduce:
1. Replace ~/.kde4/share/config/digikamrc with the contents of https://github.com/l0b0/tilde/blob/8b59ea801f51f2bc6c5753cabced8f13de5235a6/.kde4/share/config/digikamrc
2. Run Digikam
3. Click on a RAW image (tested with CR2)
4. Click "Image Editor"
5. Click "Import"

Actual Results:  
At this point the configuration file has randomly changed the exposure correction shift value as follows:

@@ -862,7 +873,7 @@ EnableCACorrection=true
 Es Median Filter Passes=0
 Expo Correction=true
 Expo Correction Highlight=0
-Expo Correction Shift=1
+Expo Correction Shift=0.994
 FineExposure=0
 FixColorsHighlights=false
 Four Color RGB=false

Expected Results:  
The exposure correction shift should stay the same, since I did not change it.

Further steps which change the configuration in invalid ways:

6. Closing the image editor results in the following addition to the configuration diff:

@@ -433,7 +436,7 @@ Speed=1
 
 [ImageViewer Settings]
 AutoBrightness=false
-AutoZoom=true
+AutoZoom=false
 BackgroundColor=0,0,0
 Black Point=0
 Brightness Multiplier=1

Workaround: Reset configuration.
Comment 1 Maik Qualmann 2016-06-17 18:55:20 UTC 
This is not an bug, the value from the GUI is calculated. This is the function:

drawdecoderwidget.cpp:161

/** Convert Exposure correction shift E.V value from GUI to Linear value needs by libraw decoder.
     */
    double shiftExpoFromEvToLinear(double ev) const
    {
        // From GUI : -2.0EV => 0.25
        //            +3.0EV => 8.00
        return (1.55*ev + 3.35);
    }

The variable AutoZoom is Fit to Window. If reset on a restart, is correct.

Maik
Comment 2 Victor Engmark 2016-06-17 20:03:30 UTC 
How is it possible that reverting a valid user setting on restart is not a bug?
Comment 3 Maik Qualmann 2016-06-17 20:16:29 UTC 
The value from the config file for the GUI is calculated back again. The value 0.994 is 1.0 for the GUI.

Maik
Comment 4 Victor Engmark 2016-06-17 20:36:46 UTC 
(In reply to Maik Qualmann from comment #3)
> The value from the config file for the GUI is calculated back again. The
> value 0.994 is 1.0 for the GUI.

Thanks; that's clear now. I was wondering about the following statement:

> The variable AutoZoom is Fit to Window. If reset on a restart, is correct.
Comment 5 Victor Engmark 2016-06-19 19:42:45 UTC 
@gilles: Why was this marked "works for me"? Were you not able to reproduce it?
Comment 6 caulier.gilles 2016-06-19 19:56:35 UTC 
because it work as expected. We cannot reproduce the problem.

Gilles Caulier