| Summary: | korganizer 5.1.3 does not save change of appointment date. | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | Carioca <h6zb8-kdebugs20120801> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bruno, faure |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwidgetsaddons/e716a6af3dd562288c02a20387ab5cee2069e95c | Version Fixed In: | |
|
Description
Carioca
2016-06-11 05:51:44 UTC
Indeed, confirmed, and fixed. https://phabricator.kde.org/D8908 *** Bug 328145 has been marked as a duplicate of this bug. *** Git commit e716a6af3dd562288c02a20387ab5cee2069e95c by David Faure. Committed on 24/01/2018 at 10:36. Pushed by dfaure into branch 'master'. KDateComboBox: fix dateChanged() not emitted after typing a date Summary: When editing an event in korganizer, if I was typing digits to edit a date, rather than using another method (date popup; key_up; etc.), then the change wouldn't be saved. I would say that on focus-out or Key_Enter, we want to "commit" the edited date into the final date as desired by the user, by emitting dateEntered() and dateChanged(), to match the other edit methods. The documentation clarifies what I think was the intent of the 3 signals, and the unittest checks that the signals are emitted accordingly. Test Plan: Unittest passes; korganizer use case is fixed. Reviewers: cfeck, dvratil, mlaurent Reviewed By: mlaurent Subscribers: mlaurent, anthonyfieroni, #frameworks, #kde_pim Tags: #frameworks Differential Revision: https://phabricator.kde.org/D8908 M +68 -0 autotests/kdatecomboboxtest.cpp M +1 -0 autotests/kdatecomboboxtest.h M +16 -0 src/kdatecombobox.cpp M +5 -4 src/kdatecombobox.h https://commits.kde.org/kwidgetsaddons/e716a6af3dd562288c02a20387ab5cee2069e95c |