Bug 364125

Summary: git master 2016-06-09 - Speed effect corrupts saved effect stack
Product: [Applications] kdenlive Reporter: Evert Vorster <evorster>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: wegwerf-1-2-3
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Video clip of the issue
Project file with the corruption

Description Evert Vorster 2016-06-09 06:26:24 UTC 
Hi there... 
Seems that a regression has slipped in here. 
I have a stack of effects that I usually apply to GoPro footage. 
It's basically defish, levels, white balance, saturation and sharpening. Because I use the stack often, I save it in a group. 

When I put the speed effect and the custom stack on a clip, it all looks OK. 
However, when I save the project, and load it again, the saved stack now only has two defish filters in it. (And they don't start from the first frame, either)



Reproducible: Always

Steps to Reproduce:
1. Save a custom effect stack (defish, levels, white balance, saturation, sharpen)
2. Put speed effect on a clip in timeline.
3. Put saved custom stack on same clip.
4. Save project
5. Revert to saved project.

Actual Results:  
Effect stack is not preserved during save

Expected Results:  
The effect stack to be restpred exactly the way it was before it was saved.
Comment 1 Wegwerf 2016-08-04 16:28:10 UTC 
Evert, do you still see this regression?
Comment 2 Wegwerf 2016-08-08 16:06:47 UTC 
Evert, ping ;) ... can you please check if you still see this regression?
Comment 3 Evert Vorster 2016-08-09 06:15:07 UTC 
Hi there... 

This is still present. 
Just apply a stack of effects to a clip, then apply the speed effect. 
When adjusting the speed effect, the keyframes in the effect stack suddenly fall outside the clip, and in my case it just goes black. 

-Evert-
Comment 4 Evert Vorster 2016-08-09 06:22:58 UTC 
Created attachment 100506 [details]
Video clip of the issue
Comment 5 Evert Vorster 2016-08-09 06:24:20 UTC 
Created attachment 100507 [details]
Project file with the corruption

Added a clip and a project file of the issue in action, on the git master of 2016-08-08
Comment 6 Evert Vorster 2016-09-13 18:58:12 UTC 
This works properly with the clip job for speed effect. 

Thanks for fixing this