Bug 363927

Summary:	KF5 port of the ipfilter plugin (in progress)
Product:	[Applications] ktorrent	Reporter:	Matt Scheirer <matt.scheirer>
Component:	general	Assignee:	Joris Guisson <joris.guisson>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	andrius, fonic.maxxim, luke-jr+kdebugs, matt.scheirer, moi
Priority:	NOR
Version First Reported In:	5.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	KF5 port of IP Filter Plugin Part 1

Description Matt Scheirer 2016-06-04 02:05:22 UTC

I spent last weekend working a bit on porting the ipfilter plugin, because for some reason I'm paranoid about my blocklists. Progress has been made! Attached is a patch of my current work, because I've run into a wall (not one of complexity or difficulty, just one of PITA debugging, which I will eventually get around doing). The best news out of this is that I streamlined the conversion thread significantly (it now just does download -> decompress -> generate binary) that now works with all KArchive supported formats.

I still need to fix the actual binary format generation part at the end, and when that happens I'll push this to reviewboard, I just want to at least make what I've done visible since the rest might take some time.

Reproducible: Always

Comment 1 Matt Scheirer 2016-06-04 02:06:13 UTC

Created attachment 99355 [details]
KF5 port of IP Filter Plugin Part 1

This is not finished or working! I just need to fix the binary translation next, and want to get this part public.

Comment 2 Luke-Jr 2016-06-08 03:11:19 UTC

FWIW I already did this nearly 2 months ago: https://git.reviewboard.kde.org/r/127693/

Comment 3 Matt Scheirer 2016-06-08 03:33:47 UTC

Neat, I'll rebase my changes to the downloadandconvertjob that adds 7z / xz support and just throw those on reviewboard.

This is what happens when half the projects are split between phabricator and the old infrastructure though, tried checking both places for anyone working on it and still missed you!

Comment 4 Fonic 2017-01-13 22:36:12 UTC

Just found this bug. I also did this independently and submitted my changes to GitHub as I thought that's where development happens...

My port slightly differs from yours. Maybe it's helpful for completion.

https://github.com/KDE/ktorrent/pull/3