Bug 363726

Summary: Kpat crashes while asking for a "new ricycle of a game" (F5 like) via the menu button
Product: [Applications] kpat Reporter: stakanov
Component: generalAssignee: Stephan Kulow <coolo>
Status: RESOLVED FIXED    
Severity: crash CC: aacid, andrew.crouthamel, kde-games-bugs-null, pseudo-account
Priority: NOR Keywords: drkonqi
Version First Reported In: 3.6   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://commits.kde.org/kpat/9fedf33f5618a11424d615b1d8a784a8587ce237 Version Fixed In:
Sentry Crash Report:
Attachments: New crash information added by DrKonqi

Description stakanov 2016-05-31 07:00:17 UTC 
Application: kpat (3.6)

Qt Version: 5.5.1
Operating System: Linux 4.1.21-14-default x86_64
Distribution: "openSUSE Leap 42.1 (x86_64)"

-- Information about the crash:
- What I was doing when the application crashed:
pushed the menu button that corresponds to "recycle the current game for a new start over" (shortcut for doing this would be F5, just to be clear. 

- Unusual behavior I noticed:
The application "served twice" with one picture already setup, a second superposing with a "recycle of the recycle", that is, it recycled twice even if asked once, and then immediately crashed.

-- Backtrace:
Application: KPatience (kpat), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7feeea135800 (LWP 4452))]

Thread 2 (Thread 0x7feed3aaa700 (LWP 4453)):
#0  0x00007feee5bfcbbd in poll () from /lib64/libc.so.6
#1  0x00007feedcc57422 in ?? () from /usr/lib64/libxcb.so.1
#2  0x00007feedcc5900f in xcb_wait_for_event () from /usr/lib64/libxcb.so.1
#3  0x00007feed57d53c9 in QXcbEventReader::run (this=0x1bef570) at qxcbconnection.cpp:1229
#4  0x00007feee65f832f in QThreadPrivate::start (arg=0x1bef570) at thread/qthread_unix.cpp:331
#5  0x00007feee03a60a4 in start_thread () from /lib64/libpthread.so.0
#6  0x00007feee5c04fed in clone () from /lib64/libc.so.6

Thread 1 (Thread 0x7feeea135800 (LWP 4452)):
[KCrash Handler]
#6  operator== (s1=..., s2=...) at tools/qstring.cpp:2553
#7  0x000000000043a679 in operator!= (s2=..., s1=...) at /usr/include/qt5/QtCore/qstring.h:627
#8  DealerScene::saveFile (this=0x1eb8680, io=io@entry=0x7ffd688189c0) at /usr/src/debug/kpat-15.12.3/dealer.cpp:386
#9  0x00000000004534be in MainWindow::closeEvent (this=0x1cf48e0, e=0x7ffd68818e00) at /usr/src/debug/kpat-15.12.3/mainwindow.cpp:777
#10 0x00007feee77851a1 in QWidget::event (this=this@entry=0x1cf48e0, event=event@entry=0x7ffd68818e00) at kernel/qwidget.cpp:8847
#11 0x00007feee789512b in QMainWindow::event (this=this@entry=0x1cf48e0, event=event@entry=0x7ffd68818e00) at widgets/qmainwindow.cpp:1495
#12 0x00007feee93ea6a7 in KMainWindow::event (this=this@entry=0x1cf48e0, ev=ev@entry=0x7ffd68818e00) at /usr/src/debug/kxmlgui-5.21.0/src/kmainwindow.cpp:867
#13 0x00007feee9424305 in KXmlGuiWindow::event (this=0x1cf48e0, ev=0x7ffd68818e00) at /usr/src/debug/kxmlgui-5.21.0/src/kxmlguiwindow.cpp:118
#14 0x00007feee7744e7c in QApplicationPrivate::notify_helper (this=this@entry=0x1bd48b0, receiver=receiver@entry=0x1cf48e0, e=e@entry=0x7ffd68818e00) at kernel/qapplication.cpp:3716
#15 0x00007feee7749cc8 in QApplication::notify (this=0x7ffd68819550, receiver=0x1cf48e0, e=0x7ffd68818e00) at kernel/qapplication.cpp:3499
#16 0x00007feee67d3e95 in QCoreApplication::notifyInternal (this=0x7ffd68819550, receiver=receiver@entry=0x1cf48e0, event=event@entry=0x7ffd68818e00) at kernel/qcoreapplication.cpp:965
#17 0x00007feee77807cc in sendEvent (event=<optimized out>, receiver=<optimized out>) at ../../src/corelib/kernel/qcoreapplication.h:224
#18 QWidgetPrivate::close_helper (this=0x1cf4af0, mode=mode@entry=QWidgetPrivate::CloseWithSpontaneousEvent) at kernel/qwidget.cpp:8267
#19 0x00007feee77a02f2 in handleCloseEvent (event=0x7ffd68819100, this=0x1d92bd0) at kernel/qwidgetwindow.cpp:717
#20 QWidgetWindow::event (this=0x1d92bd0, event=0x7ffd68819100) at kernel/qwidgetwindow.cpp:169
#21 0x00007feee7744e7c in QApplicationPrivate::notify_helper (this=this@entry=0x1bd48b0, receiver=receiver@entry=0x1d92bd0, e=e@entry=0x7ffd68819100) at kernel/qapplication.cpp:3716
#22 0x00007feee7749cc8 in QApplication::notify (this=0x7ffd68819550, receiver=0x1d92bd0, e=0x7ffd68819100) at kernel/qapplication.cpp:3499
#23 0x00007feee67d3e95 in QCoreApplication::notifyInternal (this=0x7ffd68819550, receiver=0x1d92bd0, event=event@entry=0x7ffd68819100) at kernel/qcoreapplication.cpp:965
#24 0x00007feee6fafdfd in sendSpontaneousEvent (event=0x7ffd68819100, receiver=<optimized out>) at ../../src/corelib/kernel/qcoreapplication.h:227
#25 QGuiApplicationPrivate::processCloseEvent (e=0x24368a0) at kernel/qguiapplication.cpp:2101
#26 0x00007feee6fb41a5 in QGuiApplicationPrivate::processWindowSystemEvent (e=e@entry=0x24368a0) at kernel/qguiapplication.cpp:1622
#27 0x00007feee6f99268 in QWindowSystemInterface::sendWindowSystemEvents (flags=...) at kernel/qwindowsysteminterface.cpp:625
#28 0x00007feed5800200 in userEventSourceDispatch (source=<optimized out>) at eventdispatchers/qeventdispatcher_glib.cpp:70
#29 0x00007feedfe89c84 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
#30 0x00007feedfe89ed8 in ?? () from /usr/lib64/libglib-2.0.so.0
#31 0x00007feedfe89f7c in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
#32 0x00007feee682ad6c in QEventDispatcherGlib::processEvents (this=0x1c20aa0, flags=...) at kernel/qeventdispatcher_glib.cpp:418
#33 0x00007feee67d1d53 in QEventLoop::exec (this=this@entry=0x7ffd688193a0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:204
#34 0x00007feee67d98f6 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1229
#35 0x00007feee6faa8ec in QGuiApplication::exec () at kernel/qguiapplication.cpp:1529
#36 0x00007feee7741605 in QApplication::exec () at kernel/qapplication.cpp:2976
#37 0x0000000000435128 in main (argc=1, argv=<optimized out>) at /usr/src/debug/kpat-15.12.3/main.cpp:338

Reported using DrKonqi
Comment 1 stakanov 2016-05-31 07:04:26 UTC 
When trying subsequently to open the game, the app states: error in opening the xml file. 

Then it opens but the respective game is not recovered any more. Statistics stay clean and to not count for a lost game.
Comment 2 stakanov 2016-06-04 09:19:38 UTC 
the correct error message is: premature end of xml file
Comment 3 Andrew Crouthamel 2018-11-01 13:42:39 UTC 
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 4 stakanov 2018-11-01 15:03:00 UTC 
Is resolved in Leap 15, 
QT 5.9.4
Plasma 5.12.6
Kpat 3.6
Comment 5 Andrey E. 2018-11-10 17:58:14 UTC 
Created attachment 116240 [details]
New crash information added by DrKonqi

kpat (3.6) using Qt 5.11.2

Last version of KDE Neon has the same error.

-- Backtrace (Reduced):
#6  0x00007fe07c35bf53 in operator== (s1=..., s2=...) at tools/qstring.cpp:3153
#7  0x0000563c0d5bed2c in operator!= (s2=..., s1=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:667
#8  DealerScene::saveFile (this=0x563c0e055a40, io=io@entry=0x7ffc37052c70) at ./dealer.cpp:380
#9  0x0000563c0d5d8a24 in MainWindow::closeEvent (this=0x563c0dd38d20, e=0x7ffc37053050) at ./mainwindow.cpp:777
#10 0x00007fe07d92fa98 in QWidget::event (this=this@entry=0x563c0dd38d20, event=event@entry=0x7ffc37053050) at kernel/qwidget.cpp:9287
Comment 6 Albert Astals Cid 2018-11-10 22:24:57 UTC 
Can you please give a more detailed description of what to do exactly to make it crash?
Comment 7 Andrew Crouthamel 2018-11-11 03:29:37 UTC 
Thanks for the update!
Comment 8 Andrey E. 2018-11-11 06:42:36 UTC 
(In reply to Albert Astals Cid from comment #6)
> Can you please give a more detailed description of what to do exactly to
> make it crash?

- Turn on "Autosave" option
- Win one game (for example, Spider)
- Push "New game" button
- Close application during starting new game (when not all cards are laid out)

KPatience crashes, "Unexpected end of XML" message comes after restarting.
I think that app should have stable state before closing, and OnClose handler should prevent that crash.
Comment 9 Albert Astals Cid 2018-11-11 10:58:52 UTC 
Git commit 9fedf33f5618a11424d615b1d8a784a8587ce237 by Albert Astals Cid.
Committed on 11/11/2018 at 10:58.
Pushed by aacid into branch 'Applications/18.12'.

Fix crash while closing with save state enabled

hen we were just starting the game, since there was no state yet, so
wait for the animations to quickly finish and then save the state

M  +5    -0    dealer.cpp

https://commits.kde.org/kpat/9fedf33f5618a11424d615b1d8a784a8587ce237
Comment 10 stakanov 2018-11-11 13:24:40 UTC 
Thank you! (When they say that reporting bugs is not worth it... - here we are served the answer).