Summary: | bad pixel randomness with low density with gaussian or soft mask type | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | AfsMax <mr.afsmax> |
Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andrew.crouthamel, dimula73, griffinvalley, halla |
Priority: | NOR | Keywords: | investigated, regression, triaged |
Version: | 3.0 Release Candidate | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | http://commits.kde.org/krita/2c0bc2a25f793b7773af271a5d0695794b0d49d0 | Version Fixed In: | |
Attachments: |
bug demonstration
can't be reproduced on ubuntu 16.04 |
Description
AfsMax
2016-05-29 11:46:33 UTC
Created attachment 99240 [details]
bug demonstration
Created attachment 99241 [details]
can't be reproduced on ubuntu 16.04
I can't reproduce this on ubuntu 16.04, with compiled krita git d539a80, not with several settings.
I am not sure what might be going on here.
For the initial bug report, I was on Windows 10 with the RC1. I just saw the new 3.0 version (f0cbffc, is this the final version?) and just gave it a try on Windows AND on Ubuntu 16.04. I can say that: - The problem is still present on Windows 10 in f0cbffc - I can't reproduce on Ubuntu 16.04 The bug can be reproduced only on Windows and only with the prebuilt packages. My own build (without Vc) works fine. The latest Alpha2 brebuilt .zip package is broken. Ok, I might be wrong about Vc. My local branch was at kazakov/memory-optimizations, which is a bit old. Anyway, Alpha2 package is affected. Git commit 2c0bc2a25f793b7773af271a5d0695794b0d49d0 by Boudewijn Rempt. Committed on 09/10/2016 at 11:20. Pushed by rempt into branch 'master'. Fix the randomness of KisRandomSource The root cause probably was all the places where srand was called, but after this change, textures are random again. This was a problem on Windows only, probably because the resolution of time() is too low. But that's a guess. Related: bug 345196, bug 370246, bug 367873 Closed phabricator task T3887,T3968 M +22 -5 libs/image/brushengine/kis_random_source.cpp http://commits.kde.org/krita/2c0bc2a25f793b7773af271a5d0695794b0d49d0 I still see the problem on the 3.0.91 prebuilt package on Windows 10. The tag does include the commit (and its revert(?)). It does not seem to be fixed, despite what the phabricator tasks say (T3887 and T3968). I'm unable to reproduce this on Windows in 4.1.1 or git master, could you retest with the latest version? Application Version: 4.2.0 KDE Plasma Version: 5.13.5 KDE Frameworks Version: 5.50.0 Qt Version: 5.11.1 I just retested with several releases. It looks like it is fixed in 4.1.1 . I can reproduce the bug with release 3.0.92, but not with 3.3.3 nor 4.1.1 Good. Great! Let's close this then, since it appears resolved in the latest versions. |