Bug 363532

Summary: "Allow Always" does not work
Product: [Applications] kwalletmanager Reporter: sedrubal <kde>
Component: generalAssignee: Valentin Rusu <valir>
Status: RESOLVED FIXED    
Severity: major CC: fetzt_doch, kde, rdieter
Priority: NOR    
Version: 2.0   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: http://commits.kde.org/kwallet/0a7279fc0ebab9c8dbc94c6035751d0500aa342d Version Fixed In:
Sentry Crash Report:

Description sedrubal 2016-05-26 00:31:23 UTC 
I enabled that kwallet prompts me if an application wants to open a wallet. Even if I've clicked "Allow Always" for some applications, I get always prompted for the same applications again and the section "these applications are authorized to access this wallet" keeps ampty

Reproducible: Always

Steps to Reproduce:
1. Configure to prompt for authorization
2. (Re-) login to KDE session so that applications want to access kwallet
3. Click "Allow Always"
4. Re-login to KDE and you'll get prompted again for the same applications
Comment 1 Rex Dieter 2016-05-26 11:36:39 UTC 
Can you give some specific examples of "some applications"?
Comment 2 sedrubal 2016-05-26 11:43:34 UTC 
Yes, of course: kwallet-manager itself, kmail, owncloud-desktop kded5, kontact, akonadi_resources
Comment 3 fetzt_doch 2016-06-06 11:27:30 UTC 
I can absolutely confirm this bug for kubuntu 15.10 and it is still persisting in kubuntu 16.04.
Comment 4 Burkhard Lück 2016-08-11 13:05:41 UTC 
Git commit 0a7279fc0ebab9c8dbc94c6035751d0500aa342d by Burkhard Lück.
Committed on 11/08/2016 at 13:04.
Pushed by lueck into branch 'Applications/16.08'.

Fix wrong path to existing wallet files

the wallet files *.kwl + *.salt are located in a subdir "/kwalletd/" in QStandardPaths::GenericDataLocation
see
kwalletmanager.cpp:390:    const QString path = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/kwalletd/";
kwalletmanager.cpp:420:    const QString destinationDir = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/kwalletd/";

But the code in konfigurator.cpp used QStandardPaths::DataLocation) + "/kwallet/" therefore existing wallet files were not found
and the config entries "Auto Allow" and "Auto Deny" were always deleted
With the patch the config entries "Auto Allow" and "Auto Deny" are preserved in kwalletrc
REVIEW:128354
Related: bug 358469

M  +2    -2    src/konfigurator/konfigurator.cpp

http://commits.kde.org/kwallet/0a7279fc0ebab9c8dbc94c6035751d0500aa342d