Bug 363257

Summary: Color-picker tool (Ctrl+click) not available after selecting a layer
Product: [Applications] krita Reporter: David REVOY <info>
Component: Layer StackAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: scottpetrovic
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/krita/34884c11fbe604ca759de069f559aa073905d26c Version Fixed In:
Sentry Crash Report:

Description David REVOY 2016-05-19 04:53:48 UTC 
Hi, 

How to reproduce:
===============
1. Open a new document (eg. A4, 300ppi) 
2. Paint/create three layers (random colored stroke) on it (not empty layers)
3. Select a layer in the layer stack docker and try to pick the color of the stroke with Ctrl+click.
4. Repeat (3) to trigger the bug. It should happens all the time. 

Result:
======
The Color picker tool is locked for 1 big second after layer selection. So, it feels like the color-picker is not working. After this delay, the color-picker works.
Comment 1 Scott Petrovic 2016-05-21 23:49:57 UTC 
I can confirm that there is something going on with changing layers an how it affects the canvas cursor.

It seems like the bug has to do something with changing layers and a delay that is created with that. You don't need a bigger document for this to happen. It can just be a small one.

Just create a new document and a new layer. Switch layers and try to hold a key like Control. You will see the cursor doesn't update for about a second or two.
Comment 2 Dmitry Kazakov 2016-05-25 12:59:51 UTC 
Git commit 34884c11fbe604ca759de069f559aa073905d26c by Dmitry Kazakov.
Committed on 25/05/2016 at 12:59.
Pushed by dkazakov into branch 'master'.

Fix the delay before passing focus to the canvas after working with non-input widgets

Now we use a "hackish" way to distinguish if the source widget
is an input widget. And if it is, then the delay will be much
shorter, only half a second.


Fixes T2498
Fixes T2540
Related: bug 363043

M  +14   -5    libs/image/kis_timed_signal_threshold.cpp
M  +6    -0    libs/image/kis_timed_signal_threshold.h
M  +39   -3    libs/ui/input/kis_input_manager_p.cpp

http://commits.kde.org/krita/34884c11fbe604ca759de069f559aa073905d26c