Bug 363245

Summary: Fails to compile due to FFMPEG API change [kf5 branch]
Product: [Applications] amarok Reporter: beojan <beojan>
Component: generalAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED LATER    
Severity: major CC: gmt
Priority: NOR    
Version First Reported In: kf5   
Target Milestone: 2.9   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description beojan 2016-05-19 00:05:43 UTC
Amarok fails to build due to changes in the FFMPEG API, with the errors: 

```
/home/beojan/amarok/src/musicbrainz/MusicDNSAudioDecoder.cpp:246:36: error: use of undeclared identifier 'avcodec_alloc_frame'
                    decodedFrame = avcodec_alloc_frame();
                                   ^
/home/beojan/amarok/src/musicbrainz/MusicDNSAudioDecoder.cpp:254:25: error: use of undeclared identifier 'avcodec_get_frame_defaults'
                        avcodec_get_frame_defaults( decodedFrame );
                        ^
/home/beojan/amarok/src/musicbrainz/MusicDNSAudioDecoder.cpp:280:9: warning: 'av_free_packet' is deprecated [-Wdeprecated-declarations]
        av_free_packet( &packet );
        ^
/usr/include/mygpo-qt/../libavcodec/avcodec.h:4040:6: note: 'av_free_packet' has been explicitly marked deprecated here
void av_free_packet(AVPacket *pkt);
     ^
/home/beojan/amarok/src/musicbrainz/MusicDNSAudioDecoder.cpp:286:5: warning: 'av_free_packet' is deprecated [-Wdeprecated-declarations]
    av_free_packet( &avpkt );
    ^
/usr/include/mygpo-qt/../libavcodec/avcodec.h:4040:6: note: 'av_free_packet' has been explicitly marked deprecated here
void av_free_packet(AVPacket *pkt);
     ^
```

I am using the kf5 branch. 

Reproducible: Always
Comment 1 Myriam Schweingruber 2016-05-19 14:18:38 UTC
And that is the problem: the kf5 branch is still pre-alpha, there hasn't been not even a technical preview because many things haven't been implemented yet. So it is way too early to report bugs against it. You are of course welcome to help in the development.
Comment 2 Gregory M. Turner 2016-08-21 08:37:20 UTC
That may be one problem; another might be that maintainers, early adopters, and eventually amarok's own developers will need to independently track down and test:

https://build.opensuse.org/package/view_file/openSUSE:Factory/amarok/amarok-ffmpeg3.0.patch?rev=99,

after they came here to try to determine if a reasonable solution had been identified, yet, by the kf5 amarok community.  Thankfully, both problems have the same solution.