Bug 363043

Summary:	Can't use shortcuts for canvas inputs after using the layers docker
Product:	[Applications] krita	Reporter:	Tricia <triciacunningham>
Component:	Shortcuts and Canvas Input Settings	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	dimula73, halla
Priority:	NOR
Version First Reported In:	3.0 Beta
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/krita/34884c11fbe604ca759de069f559aa073905d26c	Version Fixed In:
Sentry Crash Report:
Attachments:	tabletlog

Description Tricia 2016-05-13 20:26:39 UTC

After using the layers docker to switch layers, hide layers, or anything like that, I can't use any canvas input shortcuts such as pan, rotate, or zoom without first clicking into the canvas or using the scroll bars. 

Reproducible: Always

Steps to Reproduce:
1. Create new canvas
2. Select a different layer
3. Try to zoom or pan

Actual Results:  
Canvas won't react. If trying to pan, I'll just draw a stroke on the canvas, need to undo, and then be able to pan using my shortcut. 


I am running Windows 7 and using a Wacom Cintiq 24 HD. I was not having this behavior in the last release.

Comment 1 Tricia 2016-05-13 20:31:33 UTC

Created attachment 98950 [details]
tabletlog

Comment 2 Halla Rempt 2016-05-14 09:50:07 UTC

Hi Tricia,

Thanks for your report. I can confirm the issue on Linux, too -- and it's strange because this release was supposed to have this issue fixed!

Comment 3 Dmitry Kazakov 2016-05-16 12:21:40 UTC

Hi,  Tricia and Boud!

There is a bit of weirdness in the design. Basically, I don't know if there is any input box is selected atm and if I can transfer input focus to the canvas or not. So our current strategy is:

1) Move the focus to the canvas if the user has been *moving* the cursor over the canvas for at least 2 seconds. It doesn't work if you just stop the cursor over the canvas. This is done to let the user type in the input boxes around the canvas without the need of keeping the cursor over them.

2) The focus is also transferred if you *click* on the canvas.

And I cannot just transfer the focus to the canvas on a key press, because in that case shortcut '5' will become ambiguous. You will not be able to type a letter '5' into any input box in the dockers unless you keep the cursor over it, which is quite annoying.


Right now to workaround this bug you can just move the cursor over the canvas for two seconds or start any canvas shortcut that involves mouse button press.

Comment 4 Dmitry Kazakov 2016-05-25 12:59:51 UTC

Git commit 34884c11fbe604ca759de069f559aa073905d26c by Dmitry Kazakov.
Committed on 25/05/2016 at 12:59.
Pushed by dkazakov into branch 'master'.

Fix the delay before passing focus to the canvas after working with non-input widgets

Now we use a "hackish" way to distinguish if the source widget
is an input widget. And if it is, then the delay will be much
shorter, only half a second.


Fixes T2498
Fixes T2540
Related: bug 363257

M  +14   -5    libs/image/kis_timed_signal_threshold.cpp
M  +6    -0    libs/image/kis_timed_signal_threshold.h
M  +39   -3    libs/ui/input/kis_input_manager_p.cpp

http://commits.kde.org/krita/34884c11fbe604ca759de069f559aa073905d26c