Bug 363030

Summary:	Text cursor can't be placed to the end of text
Product:	[Applications] krita	Reporter:	rkfg
Component:	Tool/Text	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version First Reported In:	3.0 Beta
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
URL:	http://files.kde.org/krita/3/linux/devbuilds/krita-3.0-Beta-master-562442e-x86_64.appimage
Latest Commit:	http://commits.kde.org/krita/f843bdfd0859f24077ae0fe48d752a78ffbdf64e	Version Fixed/Implemented In:
Sentry Crash Report:

Description rkfg 2016-05-13 15:08:35 UTC

You can't set the text cursor position after the last character, only before it. At the same time it's actually after it so when you press Delete it removes the character after itself.

1. Add new artistic text.
2. Note that the blinking cursor is located before the last character.
3. Press Backspace and observe the last character being deleted like if you've pressed Delete.
4. Press Left Arrow and see no difference but the cursor is now logically before the last character.
5. Press Backspace again, the next-to-last character is deleted now as it should be.

Comment 1 Halla Rempt 2016-05-14 09:53:40 UTC

Hi,

Thanks for your report. It's not a regression: 2.9 had this bug as well. The text tools are pretty bad, which is why we're now doing a fund raiser to make it possible to replace them entirely: https://www.kickstarter.com/projects/krita/krita-2016-lets-make-text-and-vector-art-awesome

Comment 2 Halla Rempt 2016-05-14 09:55:24 UTC

Eek, I was wrong: this doesn't happen in 2.9, I was testing with the wrong build. So it is a regression. The point about the text tool needing replacing stands, though!

Comment 3 Halla Rempt 2016-05-14 10:00:10 UTC

Git commit f843bdfd0859f24077ae0fe48d752a78ffbdf64e by Boudewijn Rempt.
Committed on 14/05/2016 at 09:59.
Pushed by rempt into branch 'master'.

Revert "First commit of improved RTL text editing for the artistic text shape"

This reverts commit 0ab16affe98e4b0957565bc6f43da9cd26e5f609.

This commit broke the cursor for LTR languages, selecing the font
and the font size.
Related: bug 363025, bug 363026

M  +19   -52   plugins/flake/artistictextshape/ArtisticTextShape.cpp
M  +2    -8    plugins/flake/artistictextshape/ArtisticTextShape.h

http://commits.kde.org/krita/f843bdfd0859f24077ae0fe48d752a78ffbdf64e