Bug 362992

Summary:	Device Notifier is shown when no drive is mounted and is not set hidden when a device has been removed
Product:	[Plasma] plasmashell	Reporter:	Sudhir Khanger <sudhir>
Component:	Disks & Devices widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dflogeras2, kde
Priority:	NOR
Version First Reported In:	5.6.3
Target Milestone:	1.0
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-workspace/6c0b1e542c19e00e045074a01e4daf992ec59e56	Version Fixed In:	5.7.0
Sentry Crash Report:
Attachments:	konsole showing no attachment device notifier widget visible dolphin showing mounted drive but no device notifier

Description Sudhir Khanger 2016-05-12 18:07:32 UTC

Starting Plasma 5.6 I notice that Device Notifier icon stays in the system tray even when you remove the external device. I have to click at least twice somewhere in the system tray. The opposite also happens that is device will be mounted but no device notifier icon/notification will be triggered.

I think you have to force system tray refresh for Device notification widget to work properly.

Reproducible: Always




Please see the attached images.

Comment 1 Sudhir Khanger 2016-05-12 18:08:44 UTC

Created attachment 98934 [details]
konsole showing no attachment device notifier widget visible

Comment 2 Sudhir Khanger 2016-05-12 18:09:30 UTC

Created attachment 98935 [details]
dolphin showing mounted drive but no device notifier

Comment 3 Kai Uwe Broulik 2016-05-12 18:12:29 UTC

Noticed the same just yesterday, confirmed.

Comment 4 Kai Uwe Broulik 2016-06-13 08:12:12 UTC

Git commit 6c0b1e542c19e00e045074a01e4daf992ec59e56 by Kai Uwe Broulik.
Committed on 13/06/2016 at 08:10.
Pushed by broulik into branch 'master'.

[Device Notifier] Be more declarative

Instead of having a bunch of handlers in various places messing with various settings,
try to use declarative bindings where possible.

* Remove separate passive timer, instead re-use the pendingDelegateRemoval property
  which has its own timer. This way, when a device is unmounted, device notifier stays
  active until the notification has cleared, however, when the device is yanked out manually,
  it disappears right away
* Don't break binding on Plasmoid.active to ensure its state is always proper depending on
  whether a device or not is present (the linked bug)
* Create tooltip declaratively rather than imperatively
FIXED-IN: 5.7.0

Differential Revision: https://phabricator.kde.org/D1793

M  +0    -9    applets/devicenotifier/package/contents/ui/FullRepresentation.qml
M  +22   -20   applets/devicenotifier/package/contents/ui/devicenotifier.qml

http://commits.kde.org/plasma-workspace/6c0b1e542c19e00e045074a01e4daf992ec59e56

Comment 5 Kai Uwe Broulik 2016-06-30 19:21:32 UTC

*** Bug 364940 has been marked as a duplicate of this bug. ***