Bug 362977

Summary: [16.04.1 regression] Crash after compressing to zip from service menu
Product: [Applications] ark Reporter: Elvis Angelaccio <elvis.angelaccio>
Component: generalAssignee: Elvis Angelaccio <elvis.angelaccio>
Status: RESOLVED FIXED    
Severity: crash CC: bblrlo, dariusz.tereszkiewicz, germano.massullo, martin.sandsmark, rakuco, rthomsen6, simonandric5
Priority: NOR Keywords: regression
Version: 16.04.1   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 16.08.0
Sentry Crash Report:
Attachments: Backtrace

Description Elvis Angelaccio 2016-05-12 10:17:44 UTC 
There seems to be a crash after creating a zip from the dolphin service menu.
16.04 works fine, so it looks like a regression...

Reproducible: Always
Comment 1 Elvis Angelaccio 2016-05-12 10:18:12 UTC 
Created attachment 98931 [details]
Backtrace
Comment 2 Martin Sandsmark 2016-05-15 17:21:55 UTC 
according to git bisect, https://quickgit.kde.org/?p=ark.git&a=commit&h=8c21ca3ae9326d772e2f037c4f79ba9ca10af6ad is the commit introducing the crash.
Comment 3 Martin Sandsmark 2016-05-15 17:26:13 UTC 
Readding this disconnect fixes it:

diff --git a/kerfuffle/jobs.cpp b/kerfuffle/jobs.cpp
index b61e126..6f508f9 100644
--- a/kerfuffle/jobs.cpp
+++ b/kerfuffle/jobs.cpp
@@ -175,6 +175,8 @@ void Job::onFinished(bool result)
 {
     qCDebug(ARK) << "Job finished, result:" << result << ", time:" << jobTimer.elapsed() << "ms";
 
+    archiveInterface()->disconnect(this);
+
     emitResult();
 }
Comment 4 Elvis Angelaccio 2016-05-15 17:28:59 UTC 
(In reply to Martin Sandsmark from comment #3)
> Readding this disconnect fixes it

But unfortunately that disconnect() seems to cause another crash (seem the commit message).
We should try to find another fix, if possible.
Comment 5 Elvis Angelaccio 2016-05-16 10:13:38 UTC 
Btw I cannot reproduce this on master, where we made deep changes to the jobs/cliinterface architecture.
Comment 6 Elvis Angelaccio 2016-05-21 15:23:06 UTC 
(In reply to Elvis Angelaccio from comment #5)
> Btw I cannot reproduce this on master, where we made deep changes to the
> jobs/cliinterface architecture.

For this reason, I'm gonna mark this as fixed in Applications/16.08

While it is bad to introduce a crash in a stable branch's minor release, it would be also bad to reintroduce another bug previously fixed.
Comment 7 Elvis Angelaccio 2016-08-27 15:36:28 UTC 
*** Bug 367885 has been marked as a duplicate of this bug. ***
Comment 8 Elvis Angelaccio 2016-09-09 11:08:00 UTC 
*** Bug 368441 has been marked as a duplicate of this bug. ***
Comment 9 Elvis Angelaccio 2017-02-28 21:28:29 UTC 
*** Bug 377035 has been marked as a duplicate of this bug. ***
Comment 10 Elvis Angelaccio 2017-06-28 10:49:10 UTC 
*** Bug 381749 has been marked as a duplicate of this bug. ***