Bug 362854

Summary: Success of the `CLOSE` command is not enough and the subsequent SELECT fails because of a missing [CLOSED] response code
Product: [Applications] trojita Reporter: Jan Kundrát <jkt>
Component: IMAPAssignee: Trojita default assignee <trojita-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/trojita/e99a118eb03f15be2fad44950a36d4bf01c621fa Version Fixed/Implemented In:
Sentry Crash Report:

Description Jan Kundrát 2016-05-09 14:47:10 UTC 
16:44:25.460 >>> y23 SELECT INBOX (QRESYNC (1457558562 1))␍␊
16:44:25.511 <<< * FLAGS (\Answered \Flagged \Deleted \Seen \Draft)␍␊
16:44:25.511 <<< * OK [PERMANENTFLAGS (\Answered \Flagged \Deleted \Seen \Draft \*)] Flags permitted.␍␊
16:44:25.511 <<< * 0 EXISTS␍␊
16:44:25.511 <<< * 0 RECENT␍␊
16:44:25.511 <<< * OK [UIDVALIDITY 1457558562] UIDs valid␍␊
16:44:25.511 <<< * OK [UIDNEXT 1] Predicted next UID␍␊
16:44:25.511 <<< * OK [HIGHESTMODSEQ 1] Highest␍␊
16:44:25.512 <<< y23 OK [READ-WRITE] Select completed.␍␊
16:44:25.512 conn Synchronizing mailbox...
16:44:25.513 Imap::Mailbox::ObtainSynchronizedMailboxTask STATE_SELECTING INBOX First interesting message at 0 ()
16:44:25.513 conn Mailbox opened.
16:44:25.514 Imap::Mailbox::ObtainSynchronizedMailboxTask STATE_SELECTING INBOX Completed
16:44:25.514 Imap::Mailbox::KeepMailboxOpenTask attached to INBOX Activated
16:44:29.942 >>> y24 CLOSE␍␊
16:44:29.984 <<< y24 OK Close completed.␍␊
16:44:29.984 Imap::Mailbox::DeleteMailboxTask Activated
16:44:29.985 >>> y25 DELETE INBOX␍␊
16:44:30.022 <<< y25 NO INBOX can't be deleted.␍␊
16:44:30.022 Imap::Mailbox::DeleteMailboxTask Failed: Couldn't delete mailbox
16:44:33.690 Imap::Mailbox::ObtainSynchronizedMailboxTask STATE_WAIT_FOR_CONN dev.gentoo Activated
16:44:33.691 conn Waiting for another mailbox...
16:44:33.694 Imap::Mailbox::ObtainSynchronizedMailboxTask STATE_SELECTING dev.gentoo Synchronizing mailbox
16:44:33.709 >>> y26 SELECT "dev.gentoo" (QRESYNC (1457558573 61 (33,50,58,62,64 83,100,108,112,114)))␍␊
16:44:33.839 <<< * FLAGS (\Answered \Flagged \Deleted \Seen \Draft)␍␊
16:44:33.839 <<< * OK [PERMANENTFLAGS (\Answered \Flagged \Deleted \Seen \Draft \*)] Flags permitted.␍␊
16:44:33.839 <<< * 64 EXISTS␍␊
16:44:33.839 <<< * 0 RECENT␍␊
16:44:33.839 <<< * OK [UIDVALIDITY 1457558573] UIDs valid␍␊
16:44:33.839 <<< * OK [UIDNEXT 115] Predicted next UID␍␊
16:44:33.839 <<< * OK [HIGHESTMODSEQ 61] Highest␍␊
16:44:33.839 <<< y26 OK [READ-WRITE] Select completed.␍␊
16:44:33.840 Imap::Mailbox::KeepMailboxOpenTask attached to dev.gentoo Failed: The connection is being killed for unspecified reason
16:44:33.840 Imap::Mailbox::ObtainSynchronizedMailboxTask STATE_SELECTING dev.gentoo Failed: The connection is being killed for unspecified reason
16:44:33.840 *** Connection killed.
16:44:33.840 UnexpectedResponseReceived Server did not send the CLOSED response code to notify us that the previous mailbox was successfully closed. Stopping the sync to prevent data loss.␊␊
Comment 1 Jan Kundrát 2016-05-21 14:51:58 UTC 
Git commit e99a118eb03f15be2fad44950a36d4bf01c621fa by Jan Kundrát.
Committed on 11/05/2016 at 08:24.
Pushed by gerrit into branch 'master'.

IMAP: Do not expect [CLOSED] when CLOSE succeeded

The idea is that the CLOSE's tagged response handler should update the
connection state.

We only issue the (destructive by its nature) CLOSE command upon
deleting a currently selected mailbox, hence the place of the fix.
Change-Id: Ic9706db2a7edfc60eb087bdc70d5345cd06329a5

M  +1    -0    src/Imap/Tasks/KeepMailboxOpenTask.cpp
M  +51   -0    tests/Imap/test_Imap_Tasks_DeleteMailbox.cpp
M  +5    -0    tests/Imap/test_Imap_Tasks_DeleteMailbox.h

http://commits.kde.org/trojita/e99a118eb03f15be2fad44950a36d4bf01c621fa