Bug 362739

Summary:	Vectors cannot have colors outside of the sRGB gamut.
Product:	[Applications] krita	Reporter:	wolthera <griffinvalley>
Component:	Layers/Vector	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	halla, osxyz
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Diff to "properly convert the qimage"

Description wolthera 2016-05-06 10:20:43 UTC

If we have a rec2020 canvas, and we make a vector layer inside it, that layer's objects will not be able to utilise the whole rec2020 gamut: Instead they're clipped to sRGB.

Reproducible: Always

Steps to Reproduce:
1. Make a wide gamut canvas, like for example, rec 2020
2. Select full red in the specific color selector.
3. Make a vector with the geometric tools, make sure it's filled with the ful red.
4. Color pick the red: it's sRGB red instead of full red in rec2020



svg 1.1 has rules for wide gamut: https://www.w3.org/TR/SVG/color.html#ColorProfileDescriptions
mozilla says it's removed: https://developer.mozilla.org/en-US/docs/Web/SVG/SVG_2_support_in_Mozilla#Color
Oyranos says it was dropped: http://www.oyranos.org/2010/06/css3-and-icc-colour-profiles/
inkscape has it.

I think this is in the category of 'ask inkscape team what's up'

Comment 1 eliotJ 2016-05-18 23:51:14 UTC

Hi

Does it's also exists in Krita v2.9.11 or does it's a regression in v3.0 ?

Comment 2 Halla Rempt 2016-12-08 10:07:46 UTC

Yes -- I'm not surprised, that's because Flake uses QPainter internally. So, a vector layer is painted on a QImage, and the QImage is converted to a KisPaintDevice.

QImage and QPainter cannot handle anything other than sRGB; there is a nasty bug here though because the conversion assumes that any colorspace with the RGBA id is sRGB...

Comment 3 Halla Rempt 2016-12-08 10:19:29 UTC

Created attachment 102682 [details]
Diff to "properly convert the qimage"

Actually, I tried to do the conversion properly, but that gives more problems: it means for instance that the color used in the calligraphy tool changes after the stroke is completed and becomes different from the one selected in the color selector.

I think that we shouldn't touch this area and keep it as it is: the only possible solution is to implement painting in flake directly on KisPaintDevices, and that means implemented a QPainter that can work on a KisPaintDevice. 

We've tried that several times and always failed.