Bug 362551

Summary:	Some fixes in CMakeLists.txt that prevent a FTBFS
Product:	[Applications] trojita	Reporter:	Alf Gaida <agaida>
Component:	Other	Assignee:	Trojita default assignee <trojita-bugs>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	pali.rohar
Priority:	NOR
Version First Reported In:	git
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
URL:	https://github.com/debian-lxqt/trojita/blob/lxqt-snapshots/latest/debian/patches/10-cmakelists.txt.patch
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Alf Gaida 2016-05-01 15:06:23 UTC

The current checkout fails to build because of two missed files in the CMakeLists.txt. This was the important bug. It would be nice if you could provide the soname/version too, it's in the linked patch.

Reproducible: Always

Steps to Reproduce:
1. clone
2. cmake
3. make

Actual Results:  
build fails

Expected Results:  
it should compile

Comment 1 Alf Gaida 2016-05-01 15:08:20 UTC

sorry, first time i used the kde bug tracker - link to the patch:
https://github.com/debian-lxqt/trojita/blob/lxqt-snapshots/latest/debian/patches/10-cmakelists.txt.patch

Comment 2 Thomas Lübking 2016-05-01 15:48:38 UTC

https://quickgit.kde.org/?p=trojita.git&a=history&h=701076a8fe1ceb06928f3554b7c1cd64f5f38054&f=src%2FGui%2FFindBarMixin.cpp

I'd say there's a problem with your checkout?

Comment 3 Alf Gaida 2016-05-01 16:35:55 UTC

Shame on me, you are right. Fixed my checkout. The soversion/version thing remains. Should i file a new bug?

Comment 4 Pali Rohár 2016-05-01 16:53:17 UTC

Why soversion? That library does not have any public API/ABI, so versioning does not make sense...

Comment 5 Alf Gaida 2016-05-01 16:56:14 UTC

then it would be better to install the lib outside of the search path as private lib - prevent lintian complaining about it.

Comment 6 Jan Kundrát 2016-05-01 18:28:53 UTC

Hi Alf, if there's a path about which various distributions agree that we could use for these bits, I'm all for using that. However, last time I had this conversation nobody offered any location. Using something like libexec/trojita would require some RPATH hacking which seems quite fishy to me -- and the distro guys agreed rather than saying "oh screw it, everybody does it that way".

Comment 7 Alf Gaida 2016-05-01 20:59:02 UTC

ok, i'm fine with, no big deal. And thanks again for pointing me into the right direction - false ownership in the source dir preventing correct updates - so trivial i overlooked it for a month.