Bug 362530

Summary:	Specific Color Selectors reads correct HDR values from color picker but does not enable to set anything out of 0..1 range.
Product:	[Applications] krita	Reporter:	peeweek
Component:	Color Selectors	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	griffinvalley, kram.fama, tamtamy.tymona
Priority:	NOR
Version First Reported In:	3.0 Beta
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	EXR File containing HDR Data

Description peeweek 2016-05-01 09:01:39 UTC

When working with 16 or 32 bit EXR containing HDR values (RGB values greater than 1.0f), color picker displays correct floating point values in Specific Color Selector.

However, if you try to manually input values greater than 1.0, the color selector does not comply and allows you only to enter values in the 0.0 to 1.0 range.

Reproducible: Always

Steps to Reproduce:
1. Open EXR HDR file.
2. Using colorpicker pick a HDR value greater than one, check value in Specific Color Selector.
3. In Specific Color Selector, try to input values greater than 1.0

Actual Results:  
Input Values are clamped to 0..1 range.

Expected Results:  
Values should be unclamped and SCS should allow you to input HDR Values.

Comment 1 peeweek 2016-05-01 09:03:42 UTC

Created attachment 98721 [details]
EXR File containing HDR Data

Comment 2 wolthera 2016-05-01 10:00:21 UTC

It's not really clamped as much as that it will not allow values that wouldn't be visible with the current ocio settings. So if you go into the lutdocker and set the current whitepoint/exposure higher you can set the maximum value higher.

I agree it's awkward, and I wish I understood the lutdocker better so I could change it quickly, but sadly not enough time.

Comment 3 peeweek 2016-05-01 13:58:29 UTC

Indeed, this is confusing :

I could achieve that by using a lower exposure or configuring the black/white points, but this is confusing because as far as I undrestood the problem, you can only set values from the luminance range defined in the LUT settings, which seems relatively OK for the process, but will require you to work in tonemapped range.

Anyway, maybe the Specific Color Selector (and possibly Color Sliders) could have a "color range" selector where you can define already tonemapped values (convenient for HDR painting while colorpicking) or linear values (for instance using HSL Lightness as absolute values and not relative to black/white point).

Comment 4 Tiar 2020-04-02 12:28:11 UTC

Needs discussions and some plans for sensible GUI. Note: also needs thinking how to, possibly, use it for HDR painting with HDR display, even if it cannot show HDR colors properly yet. I still see a benefit in having sliders and comboboxes for choosing colors, even if I only see them in Small Color Selector (which on my display is huge to be able to choose colors precisely) and on the canvas.

Comment 5 Tiar 2020-11-03 22:56:06 UTC

*** Bug 409824 has been marked as a duplicate of this bug. ***