Summary: | Copy To/Move To does not remember path any more | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | Peter Mühlenpfordt <devel> |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ach, bugs, cippalippa, d.schroeter, greenrd, joneall, jpelorat, miklosh, myriam, nate, null, peter_news, simon.thiel, yuriy |
Priority: | NOR | ||
Version: | Other (add details in bug description) | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/gwenview/7be60997b7478c0bb79ae6e915600de3ac17d89e | Version Fixed In: | 17.08.1 |
Attachments: | Additional patch to make the targetUrl persistent |
Description
Peter Mühlenpfordt
2016-04-29 15:36:21 UTC
Same here. Same here. Ubuntu 16.04. Same here gwenview 4:15.08.3-1 (Debian) Same here. Gwenview 15.12.3 KDE Frameworks 5.23.0 Qt 5.5.1 Kubuntu 16.04.1 Same here 16.04.3 If anyone cares, here is a workaround/hack that stores the path in a static variable. https://github.com/thielsn/gwenview/commit/2ae15844267de360c210ed15a41d7b315448b49b For a real fix the path should probably be stored in QSettings. The issue was introduced when porting to QFileDialog: https://github.com/KDE/gwenview/commit/6cd4688f7b17ede3e2c01e9b97207e0c1400325a Re-using the pseudo URL "kfiledialog:///<copyMoveOrLink>" apparently not supported in QFileDialog. *** Bug 373629 has been marked as a duplicate of this bug. *** No Fix for one year :-( I touch this bug every week. Is it a QT problem. Should we report it there? Problem persists. Very annoying if working on lots of images. Gwenviw 17.04.0, KDE 5.33.0. I've updated and improved the fix for the current version of the master branch on GitHub at https://github.com/thielsn/gwenview/commits/fix_362474 *** Bug 383532 has been marked as a duplicate of this bug. *** Git commit 7be60997b7478c0bb79ae6e915600de3ac17d89e by Christoph Feck, on behalf of Simon Thiel. Committed on 18/08/2017 at 00:42. Pushed by cfeck into branch 'Applications/17.08'. Remember paths for Copy-To and Move-To FIXED-IN: 17.08.1 Differential Revision: https://phabricator.kde.org/D6379 M +12 -9 app/fileoperations.cpp M +5 -3 app/fileoperations.h M +3 -3 app/fileopscontextmanageritem.cpp M +12 -0 lib/contextmanager.cpp M +4 -0 lib/contextmanager.h https://commits.kde.org/gwenview/7be60997b7478c0bb79ae6e915600de3ac17d89e Created attachment 108775 [details]
Additional patch to make the targetUrl persistent
Many thanks for fixing this issue. :-)
I added a few more lines to make the targetUrl persistent, as it used to be in the 'original' version.
> Additional patch to make the targetUrl persistent Thanks a lot! Can you confirm this fixes bug 374936? It would be great if you could upload the patch to https://phabricator.kde.org for review. (You'd need to register first at https://identity.kde.org/index.php?r=registration/index, see also https://community.kde.org/Infrastructure/Phabricator). If that's too much of a hassle, I can do this too, but it might take me a while to get to it and maybe you want to contribute more patches fixing some of the low-hanging fruits in Gwenview in the future too ;) Patch is uploaded here: https://phabricator.kde.org/D8747 Sorry, I can not confirm bug 374936 or if it's fixed by these patches. It does definitely seem like bug 374936 is a duplicate of this. *** Bug 374936 has been marked as a duplicate of this bug. *** Git commit 9056aa941e0d624094ef2762e9bbb705e56f753e by Henrik Fehlauer, on behalf of Peter Mühlenpfordt. Committed on 20/11/2017 at 16:40. Pushed by rkflx into branch 'Applications/17.12'. Persist path for "Copy/Move/Link To" to config file Summary: Additional patch to make the targetUrl persistent again. Modified storage of dirpath only instead of filepath. Save temporarily stored path of Copy/Move/Link To file dialogues from ContextManager in rc-file and restore on next start. Reviewers: rkflx Reviewed By: rkflx Subscribers: ngraham, dhaumann, rkflx Differential Revision: https://phabricator.kde.org/D8785 M +4 -1 app/fileoperations.cpp M +2 -0 app/mainwindow.cpp M +11 -0 lib/contextmanager.cpp M +3 -0 lib/contextmanager.h M +6 -0 lib/gwenviewconfig.kcfg https://commits.kde.org/gwenview/9056aa941e0d624094ef2762e9bbb705e56f753e |