Bug 362437

Summary: Problem with the onion skin when inserting new keyframes (and some onion skin's issues)
Product: [Applications] krita Reporter: Kalesi <jaquematealakalesi>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: a.c.edwards1192, dimula73, gymnastk123, jhonatassilvamoraes.12, mneko, theaquaanimegirl123
Priority: NOR    
Version: 3.0 Beta   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:

Description Kalesi 2016-04-28 19:37:47 UTC
I was testing the beta making some animations and I realize that when I insert a new keyframe (onion skin is activated), the old keyframe disappears instead of turning into red and lowing its opacity. Also, when I come back to the first keyframe and then to the new keyframe, the old one will be fine this time (red and low opacity).

Another issue that I've noticed is that, when you jump between keyframes, the opacity and color of the frames get pretty messed up. For example, let's say I have 3 keyframes (1, 2 and 3). If I'm working on the keyframe 3 and the jump back to the frame 2 everything works fine (the opacity and the color of the next frame are ok according to the onion skin presets) However, if I then jump to the frame 1 and then to the frame 3 the line becomes dark green instead of just black (assuming I'm using black as the color of the line) 

Reproducible: Always

Steps to Reproduce:
1 - Open a new file
2 - Make a keyframe
3 - Make sure to turn ON the onion skin with colors (red and green)
4 - Draw something
5 - Create a new keyframe (few frames forward in the animation timeline)  
6 - The previous keyframe will disappear instead of being affected by the onion skin


Actual Results:  
The previous keyframe will disappear instead of being affected by the onion skin

Expected Results:  
The previous keyframe should be red and low opacity (affected by the onion skin)
Comment 1 László Fazekas 2016-04-30 03:59:45 UTC
This is partially a duplicate of Bug 362151. And as I remember, this is a regression. The Onion Skin worked better before.
Comment 2 Dmitry Kazakov 2016-05-04 09:19:59 UTC

*** This bug has been marked as a duplicate of bug 362151 ***
Comment 3 Dmitry Kazakov 2016-05-04 09:56:32 UTC
Git commit 77695fea234b1228adde30011b73d7457f3a45b7 by Dmitry Kazakov.
Committed on 04/05/2016 at 09:53.
Pushed by dkazakov into branch 'master'.

Add simple hashing to the keyframe channel

Now we can easily understand that the set of key frames has changed
in the paint device, therefore making our cache invalid
Related: bug 362151
Fixes T2413

M  +15   -0    libs/image/kis_keyframe_channel.cpp
M  +6    -0    libs/image/kis_keyframe_channel.h
M  +12   -1    libs/image/kis_onion_skin_cache.cpp

http://commits.kde.org/krita/77695fea234b1228adde30011b73d7457f3a45b7