Bug 362231

Summary:	lost date in imported split operation
Product:	[Applications] skrooge	Reporter:	quentin <vey.quentin>
Component:	general	Assignee:	Stephane MANKOWSKI <stephane>
Status:	RESOLVED FIXED
Severity:	normal	CC:	stephane
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	25.1.0
Platform:	Debian testing
OS:	Linux
Latest Commit:	http://commits.kde.org/skrooge/36f2e157f83a494c4988f2ded26d354e4fcb67f5	Version Fixed/Implemented In:
Sentry Crash Report:

Description quentin 2016-04-25 11:25:02 UTC

When importing a split operation through a .csv, the date of each sub-operation is set to the value of the split operation, altough they were recorded with different dates.

Version is 1.9.3BETA

Reproducible: Always

Steps to Reproduce:
1.Create a split operation with one given date (for example 2016-04-27), set two sub-operation with different dates (2016-05-15 and 2016-05-20)
2.Export it (file->export)
3.Import it back

Actual Results:  
One split operation is imported, with the date 2016-05-15. Each sub-operation is imported with the same date, 2016-05-15

Expected Results:  
The split opration should be imported with the date 2016-04-27, and the sub-operation should be imported with the dates 2016-05-15 and 2016-105-20.

the content of the exported .csv is copied below. We can see that the date of the split operation is set to "0" (but the problem persists if the file is modified to replace the "0" with a actual date). 
The dates for each sub-operation are correctly exported, but they are lost during the import.




"date";"account";"number";"mode";"payee";"comment";"quantity";"unit";"amount";"sign";"category";"status";"bookmarked";"id";"idtransaction";"idgroup"
"0000-00-00";"test";"0";"";"";"";"0";"€";"0";"";"";"Y";"N";"1";"1";"0"
"2016-05-15";"test";"0";"";"";"test";"5";"€";"5";"+";"";"N";"N";"3";"2";"0"
"2016-05-20";"test";"0";"";"";"test";"5";"€";"5";"+";"";"N";"N";"4";"2";"0"

Comment 1 Stephane MANKOWSKI 2016-04-27 08:51:23 UTC

Hi,

In your exported csv file:
- The first line is in fact a special operation representing the initial amount of your account.
- The 2 next lines are the 2 splits of your operation.

As you can see, the dates are the dates of the suboperations. 
The date of the operation is not exported.

This is normal, the csv format is not a format allowing to export all information managed by Skrooge.

My proposal is the following one:
1- No modification for the export
2- Modification for the import to keep the suboperations dates.

Is this proposal acceptable?

Comment 2 Stephane MANKOWSKI 2016-04-27 18:52:48 UTC

Git commit 36f2e157f83a494c4988f2ded26d354e4fcb67f5 by Stephane Mankowski.
Committed on 27/04/2016 at 18:52.
Pushed by smankowski into branch 'master'.

Lost date in imported split operation

M  +1    -0    CHANGELOG
A  +4    -0    tests/input/skgtestimportcsv/362231.csv
M  +20   -0    tests/skgbankmodelertest/skgtestimportcsv.cpp

http://commits.kde.org/skrooge/36f2e157f83a494c4988f2ded26d354e4fcb67f5

Comment 3 quentin 2016-04-27 20:46:21 UTC

Thanks for the explanation about the csv.

Your proposal fits perfectly my needs, so it is good for me.