Bug 362193

Summary:	Problems in Localization with German Umlauts ('ä', 'ö', and 'ü') and 'ß'
Product:	[Applications] khangman	Reporter:	Martin Walch <walch.martin>
Component:	general	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jpwhiting, lueck
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://commits.kde.org/khangman/c757fb327dd1841d2f0793851bb86ff4ab695fc4	Version Fixed In:
Sentry Crash Report:

Description Martin Walch 2016-04-24 16:38:40 UTC

* The keys ä, ö, ü, and ß are never marked as taken (neither green nor red).
* If there is an umlaut in a word, the similar vowel is counted as correct (i.e. marked green), but the umlaut is not uncovered. For example, a 'u' will be marked green for "Künstler", although nothing is uncovered. IMO 'u' is not in the word and should be marked red.
* Any 'ß' from the kvtml file shows up as 'SS'. This is basically correct as there is no uppercase 'ß' in widespread use (this may change in the future) and instead the usual replacement is 'SS'. But what is the point of having the 'ß' key if that letter can not appear?
* Furthermore, the key 'ß' uncovers any two consecutive 's', even if this is wrong (which is typically the case if there are already two 's' in the kvtml file, like in "Wissenschaftler").


Reproducible: Always

Comment 1 Burkhard Lück 2016-04-25 05:40:45 UTC

confirmed Kubuntu 15.10 khangman 3.0 frameworks 5.15.0 Applications 15.10
and recent master compiled from sources

Comment 2 Jeremy Whiting 2020-03-03 02:03:56 UTC

Git commit c757fb327dd1841d2f0793851bb86ff4ab695fc4 by Jeremy Whiting.
Committed on 03/03/2020 at 02:01.
Pushed by whiting into branch 'master'.

Convert all letters to upper case to compare.
Since special characters for each language in khangman language.txt
files are lower case, but we show upper case in the gui special
characters were not properly getting marked as disabled or being
marked green or red when clicked. To fix always compare
upper case version of letters.
Note: if I changed letter button letter property to modelData.toUpperCase
some German characters were shown incorrectly in the gui, so show the
modelData with capitalization font, but compare toUpperCase() behind
the scenes.

M  +3    -2    src/qml/GamePage.qml

https://commits.kde.org/khangman/c757fb327dd1841d2f0793851bb86ff4ab695fc4