Bug 362152

Summary:	Font selection is not honored
Product:	[Applications] akregator	Reporter:	Chris Spiegel <cspiegel>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/kdepim/a1afb799e37c3557b623a2a6ef8ccdad2dfe63f3	Version Fixed In:	5.2.1
Sentry Crash Report:

Description Chris Spiegel 2016-04-23 17:09:42 UTC

Akregator does not honor the font setting.

Reproducible: Always

Steps to Reproduce:
1. Go to Settings→Configure Akregator
2. Under “Appearance”, choose fonts (distinctive ones are best to ensure it's clear things are going wrong)
3. Save settings
4. Open a feed

Actual Results:  
The selected fonts are not used.

Expected Results:  
The selected fonts are used.

This is version 16.04.0, which was not available in the version dropdown.

Fonts worked in 15.12.3, so there seems to have been a regression in this particular release.

This refers to the display of the information contained in the feed itself, not the display of the target web page, i.e. it's when you click on a feed, not when you click "Complete Story".

Comment 1 Laurent Montel 2016-04-24 07:03:30 UTC

which font is not working ?

Comment 2 Chris Spiegel 2016-04-24 12:38:51 UTC

No fonts are working as far as I can tell.  I set all 4 options (Standard, Fixed, Serif, Sans serif) and saw no changes in any feeds I checked, some of which included fixed fonts.  Basically, it looks like any selected fonts are simply being ignored.

On that note, font size looks to be ignored, too: I selected a different medium font size to no avail: the fonts were completely unchanged.

Comment 3 Laurent Montel 2016-04-25 04:55:18 UTC

Git commit 97bc80c0d9a82286658ae3fecbab023638e7202f by Montel Laurent.
Committed on 25/04/2016 at 04:53.
Pushed by mlaurent into branch 'Applications/16.04'.

Start to fix using font

M  +1    -1    akregator/src/formatter/html/5.2/combinedview.css
M  +1    -1    akregator/src/formatter/html/5.2/defaultnormalvisitfeed.css
M  +1    -1    akregator/src/formatter/html/5.2/defaultnormalvisitfolder.css
M  +1    -1    akregator/src/formatter/html/5.2/normalview.css

http://commits.kde.org/kdepim/97bc80c0d9a82286658ae3fecbab023638e7202f

Comment 4 Laurent Montel 2016-04-25 05:20:08 UTC

Git commit dc14b44ab640174a947f985ec4db25632081adeb by Montel Laurent.
Committed on 25/04/2016 at 05:19.
Pushed by mlaurent into branch 'Applications/16.04'.

Use font size
(still a bug as it doesn't want to change font/size when we change it from settings)

M  +1    -1    akregator/src/formatter/html/5.2/combinedview.css
M  +1    -1    akregator/src/formatter/html/5.2/defaultnormalvisitfeed.css
M  +1    -1    akregator/src/formatter/html/5.2/defaultnormalvisitfolder.css
M  +1    -1    akregator/src/formatter/html/5.2/normalview.css

http://commits.kde.org/kdepim/dc14b44ab640174a947f985ec4db25632081adeb

Comment 5 Laurent Montel 2016-04-27 05:47:37 UTC

Git commit a1afb799e37c3557b623a2a6ef8ccdad2dfe63f3 by Montel Laurent.
Committed on 27/04/2016 at 05:46.
Pushed by mlaurent into branch 'Applications/16.04'.

Fix Bug 362152 - Font selection is not honored

FIXED-IN: 5.2.1

(we need to change css too with grantlee)

D  +0    -87   akregator/src/formatter/html/5.2/combinedview.css
M  +91   -0    akregator/src/formatter/html/5.2/combinedview.html
D  +0    -75   akregator/src/formatter/html/5.2/defaultnormalvisitfeed.css
M  +75   -0    akregator/src/formatter/html/5.2/defaultnormalvisitfeed.html
D  +0    -73   akregator/src/formatter/html/5.2/defaultnormalvisitfolder.css
M  +76   -0    akregator/src/formatter/html/5.2/defaultnormalvisitfolder.html
D  +0    -73   akregator/src/formatter/html/5.2/normalview.css
M  +76   -0    akregator/src/formatter/html/5.2/normalview.html

http://commits.kde.org/kdepim/a1afb799e37c3557b623a2a6ef8ccdad2dfe63f3