Summary: | Onion skin not showing the previous image when creating a new key | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | László Fazekas <mneko> |
Component: | Animation | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | dimula73, jaquematealakalesi, mirakitty277 |
Priority: | NOR | ||
Version: | 5.2.2 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | http://commits.kde.org/krita/77695fea234b1228adde30011b73d7457f3a45b7 | Version Fixed In: |
Description
László Fazekas
2016-04-23 17:09:04 UTC
Ok, it seems like it depends on the way a new frame is created. If it is created with a special "New Frame" button, then it works fine. In Lazy Frame mode it doesn't work. *** Bug 362437 has been marked as a duplicate of this bug. *** Git commit 77695fea234b1228adde30011b73d7457f3a45b7 by Dmitry Kazakov. Committed on 04/05/2016 at 09:53. Pushed by dkazakov into branch 'master'. Add simple hashing to the keyframe channel Now we can easily understand that the set of key frames has changed in the paint device, therefore making our cache invalid Related: bug 362437 Fixes T2413 M +15 -0 libs/image/kis_keyframe_channel.cpp M +6 -0 libs/image/kis_keyframe_channel.h M +12 -1 libs/image/kis_onion_skin_cache.cpp http://commits.kde.org/krita/77695fea234b1228adde30011b73d7457f3a45b7 Nice solution! I just tried the commit and it seems perfect. For this single problem maybe even the length of the list as a hash would be enough. |