Bug 362092

marking rfe/wishlist

ping, any news or work ongoing to implement this?

(Turning libktorrent into a KF5 framework would effectively satisfy this issue too)

<offtopic>While we're at it, libktorrent in git is missings tags for recent releases, last tag I see is : v1.3.1</offoptic>

OK, scratching my own itch I think I got a good first-pass at converting libktorrent to resemble a parallel-installable framework (I used name KF5ktorrent, but that's arbitrary).  I'll attach my work-in-progress shortly.

Consumer applications will require modification of course, but it'll mostly be a matter of replacing LibKTorrent references with KF5ktorrent and link contexts using korrent with KF5::kforrent. 

If this approach is agreeable, I can then post things to reviewboard formally if you wish.

Created attachment 99344 [details]
Turn LibKTorrent into a kf5-based framework parallel-installable with prior kde4-based libktorrent

Only basic testing, builds ok, tests pass, and (modified) ktorrent buids ok too.

As an aside, po-file translations will need to be renamed too, the patch includes:

-add_definitions(-DTRANSLATION_DOMAIN="libktorrent")
+add_definitions(-DTRANSLATION_DOMAIN="libktorrent5")

but that's all so far.  I'm pretty sure more work is needed, but can solicit help from translation gurus when/if we get that far.

ping, almost 2 months, any comment on this idea?  would you rather a reviewboard submission?

Submitted to reviewboard,
https://git.reviewboard.kde.org/r/128716/

Git commit ea56ea8b5b6114f7a7e95d1eb83bdcd3cc8065aa by Rex Dieter.
Committed on 19/10/2016 at 14:28.
Pushed by rdieter into branch 'master'.

Turn libktorrent into a kf5 framework

First try at turning LibKTorrent into a kf5-based framework
parallel-installable with prior (kde4-based) libktorrent releases.
REVIEW: 128716

M  +11   -13   CMakeLists.txt
R  +1    -1    KF5TorrentConfig.cmake.in [from: LibKTorrentConfig.cmake.in - 088% similarity]
M  +1    -1    examples/ktcli/CMakeLists.txt
M  +14   -12   src/CMakeLists.txt
M  +1    -1    src/datachecker/CMakeLists.txt
M  +1    -1    src/datachecker/tests/CMakeLists.txt
M  +1    -1    src/dht/CMakeLists.txt
M  +2    -2    src/dht/tests/CMakeLists.txt
M  +1    -1    src/diskio/CMakeLists.txt
M  +2    -2    src/diskio/tests/CMakeLists.txt
M  +1    -1    src/download/CMakeLists.txt
M  +1    -1    src/download/tests/CMakeLists.txt
M  +1    -1    src/magnet/CMakeLists.txt
M  +1    -1    src/magnet/tests/CMakeLists.txt
M  +1    -1    src/mse/CMakeLists.txt
M  +1    -1    src/mse/tests/CMakeLists.txt
M  +1    -1    src/net/CMakeLists.txt
M  +2    -2    src/net/tests/CMakeLists.txt
M  +1    -1    src/peer/CMakeLists.txt
M  +4    -4    src/peer/tests/CMakeLists.txt
M  +1    -1    src/torrent/CMakeLists.txt
M  +3    -3    src/torrent/tests/CMakeLists.txt
M  +1    -1    src/tracker/CMakeLists.txt
M  +1    -1    src/upnp/CMakeLists.txt
M  +1    -1    src/util/CMakeLists.txt
M  +5    -5    src/util/tests/CMakeLists.txt
M  +1    -1    src/utp/CMakeLists.txt
M  +12   -12   src/utp/tests/CMakeLists.txt
M  +1    -1    testlib/CMakeLists.txt

http://commits.kde.org/libktorrent/ea56ea8b5b6114f7a7e95d1eb83bdcd3cc8065aa

Git commit d19cb5f86f684950c500326ca868e4a638348270 by Rex Dieter.
Committed on 19/10/2016 at 14:36.
Pushed by rdieter into branch 'master'.

Adjust to use new KF5::Torrent cmake target

See also:
REVIEW: 128716

M  +1    -1    CMakeLists.txt
M  +1    -1    ktorrent/CMakeLists.txt
M  +1    -1    libktcore/CMakeLists.txt
M  +1    -1    plugins/bwscheduler/CMakeLists.txt
M  +1    -1    plugins/downloadorder/CMakeLists.txt
M  +1    -1    plugins/infowidget/CMakeLists.txt
M  +1    -1    plugins/ipfilter/CMakeLists.txt
M  +1    -1    plugins/ipfilter/tests/CMakeLists.txt
M  +1    -1    plugins/logviewer/CMakeLists.txt
M  +1    -1    plugins/magnetgenerator/CMakeLists.txt
M  +1    -1    plugins/mediaplayer/CMakeLists.txt
M  +1    -1    plugins/scanfolder/CMakeLists.txt
M  +1    -1    plugins/scripting/CMakeLists.txt
M  +1    -1    plugins/search/CMakeLists.txt
M  +1    -1    plugins/shutdown/CMakeLists.txt
M  +1    -1    plugins/stats/CMakeLists.txt
M  +1    -1    plugins/syndication/CMakeLists.txt
M  +1    -1    plugins/upnp/CMakeLists.txt
M  +1    -1    plugins/zeroconf/CMakeLists.txt

http://commits.kde.org/ktorrent/d19cb5f86f684950c500326ca868e4a638348270