Summary: | Canvas Input Settings reset to default on restart. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | red33ed |
Component: | Shortcuts and Canvas Input Settings | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, halla, miabraha |
Priority: | NOR | Keywords: | release_blocker |
Version: | 3.0 Alpha | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | http://commits.kde.org/krita/d07168fcd08e9e2d048c396c7bf29be4cf96f021 | Version Fixed In: |
Description
red33ed
2016-04-19 17:01:08 UTC
Hi, Thanks for your report! It's a clear regression. This has something to do with KoDefaultPaths. In kis_input_profile_manager.cpp line 246: // we have one or more entries for this profile name. We'll take the last, // because that's the most local one. ProfileEntry entry = profileEntries[profileName].first(); So this assumption no longer holds in Krita 3.0, in fact we keep reloading the builtin profile from ~/share/ instead of the intended profile in ~/.local/. The 1/10 randomness is because the entries may arrive in a different order so that occasionally the first entry is in ~/.local/. Git commit d07168fcd08e9e2d048c396c7bf29be4cf96f021 by Dmitry Kazakov. Committed on 05/05/2016 at 11:09. Pushed by dkazakov into branch 'master'. Fix ordering of the resource paths (random resources/tags resets should go now!) Need help testing on all OS types now! This patch should fix the random resetting of all the user resources on restarting Krita. It happened, because Krita randomly tried to load them from the system-wide settings instead of the local user one Patch contents: 1) Resources fetched using QStandardPaths::locateAll() should have absolute priority over our own paths. That is caused by the fact that Qt sorts the returned resources by the usage priority, that is ~/.local/* will be first in the list. Whereas our resources are usually meant to be system-wide and not writable. 2) For the same reason we should never use QSet over the returned resources, since it doesn't preserve ordering 3) This patch should also fix random 'Tags' resetting when restarting Krita. Fixes T2418 CC:kimageshop@kde.org M +66 -37 libs/widgetutils/KoResourcePaths.cpp http://commits.kde.org/krita/d07168fcd08e9e2d048c396c7bf29be4cf96f021 |