Bug 361961

Summary:	Appearance of differ dialog is not suitable for source code
Product:	[Developer tools] kdevplatform	Reporter:	Alexander Potashev <aspotashev>
Component:	vcs	Assignee:	kdevelop-bugs-null
Status:	RESOLVED NOT A BUG
Severity:	wishlist	CC:	aleixpol
Priority:	LO	Keywords:	junior-jobs
Version First Reported In:	git master
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Potashev 2016-04-19 11:48:13 UTC

When I click "Diff to previous revision" or "Diff between revisions", a diff viewing dialog is opened. It has the following problems making it hard to use for source code:
 1. No highlighting of added and removed lines,
 2. The font is not fixed width,
 3. Initial dialog size is too small — probably 300x200 pixels, that's even smaller than 80x25 chars.

Reproducible: Always

Comment 1 Kevin Funk 2016-04-21 07:16:26 UTC

Confirmed. The patch review plugin usually takes care of displaying the diff inside the KDevelop main window though.

Can you make sure it is loaded?

At any rate: We need to fix the workflow where it is missing, so keeping this one open.

Comment 2 Alexander Potashev 2016-04-29 00:43:46 UTC

Oops... On the machine where I noticed the poorly formatted diff I had to disable "patchreview" because I was too lazy to install libkcomparediff2[kf5].

Comment 3 Kevin Funk 2016-04-29 07:46:20 UTC

Thanks for the confirmation.

Comment 4 Aleix Pol 2016-04-29 10:19:31 UTC

I think we should just assume that libkcomparediff is there and drop such dialog altogether.

It's not something we're maintaining appropriately anyway, since most of us never see it.

Comment 5 Kevin Funk 2016-04-29 10:41:15 UTC

Alright, I just noticed we already have a hard dependency on libkomparediff2 (when compiling the patchreview plugin). So we already require it to be there.

Marking this one as invalid then.