| Summary: | "Save File" Dialog Box not appearing upon closing program with multiple views of the same file open | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Sam Keeper <unusualcows> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | info |
| Priority: | NOR | ||
| Version First Reported In: | 3.0 Alpha | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| URL: | http://stormingtheivory.tumblr.com/post/142987820410/another-day-another-set-of-bug-reports-this-time | ||
| Latest Commit: | http://commits.kde.org/krita/87a3ba121f23f564ab8147371ae93d9eda05efda | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Sam Keeper
2016-04-18 03:27:56 UTC
I tested the bug Sam, and I can reproduce it here on last 3.0git, compiled on Ubuntu16.04. To reproduce: =========== * (menu) File > New then Create a new document * Add a random stroke on the canvas * Try to close Krita ==> You'll be prompted with the 'do you want to Save it?' dialog. Cancel * (menu) Windows > New View > Unnamed * Add a random stroke * Try to close Krita now ==> Not prompted at all, all close. Reproduced in Krita 2.9.7 too. This bug is not a 3.0 regression. Git commit 87a3ba121f23f564ab8147371ae93d9eda05efda by Dmitry Kazakov. Committed on 06/05/2016 at 10:15. Pushed by dkazakov into branch 'master'. Fix saving when multiple view of the same document are open Basically it happens because the subwindows are removed via deleteLater(), so at first all the windows get closeEvent() and only after that the start destructing itself and, therefore, unregistering themselves from KisPart. Now KisPart just checks if the view is still visible to be counted in the list of views associated with the document. Fixes T2432 M +1 -1 libs/ui/KisPart.cpp http://commits.kde.org/krita/87a3ba121f23f564ab8147371ae93d9eda05efda |