Bug 361901

Summary: git 16.04: right justified multi-line text does not correctly update in editor when editing again
Product: [Applications] kdenlive Reporter: Wegwerf <wegwerf-1-2-3>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: example Kdenlive project to reproduce the text edit update bug

Description Wegwerf 2016-04-17 16:03:00 UTC 
When creating a multi-line and right-justified text in the title editor and later editing this text again, it does not correctly update while the user edits the text. However, if for instance the second line gets longer than the first one then the text gets updated correctly again as the user edits it. Maybe this is caused by the wrong assumption that if the bounding box doesn't change then there's no redraw necessary? Please find an example project attached.

Reproducible: Always

Steps to Reproduce:
1. Open attached example project.
2. Open title clip in title editor. Please notice that the second line of text is shorter than the now current text bounding box.
3. Edit the second line of text and insert a single character: the text does not update to reflect your change.
4. Start typing more characters and suddenly the text gets updated correctly as soon as the second line gets longer than the first line and thus the bounding box changes every time as you add more characters.

Actual Results:  
Text does not update correctly on screen as you edit it.

Expected Results:  
Text should update correctly on screen as you edit it.
Comment 1 Wegwerf 2016-04-17 16:03:28 UTC 
Created attachment 98430 [details]
example Kdenlive project to reproduce the text edit update bug
Comment 2 Jean-Baptiste Mardelle 2016-04-21 22:39:02 UTC 
Git commit 84beb8edbdb103d7af26b1d49db99c289f4bb5f6 by Jean-Baptiste Mardelle.
Committed on 21/04/2016 at 22:38.
Pushed by mardelle into branch 'Applications/16.04'.

Fix editing second line of a title text not updating display

M  +1    -1    src/effectstack/graphicsscenerectmove.cpp

http://commits.kde.org/kdenlive/84beb8edbdb103d7af26b1d49db99c289f4bb5f6
Comment 3 Wegwerf 2016-04-26 15:42:52 UTC 
This is fixed now, thank you very much Jean-Baptiste! Setting this to RESOLVED FIXED.