Bug 361838

Summary:	Colour picker for Colour Clip can't work due to darkened background
Product:	[Applications] kdenlive	Reporter:	Sam Muirhead <sam>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fritzibaby, snd.noise
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	unspecified	Flags:	snd.noise: low_hanging+
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Sam Muirhead 2016-04-15 21:40:49 UTC

Trying to create a colour clip with the same colour as a background in another clip is currently impossible with the colour picker tool, due to background darkening.

Reproducible: Always

Steps to Reproduce:
When choosing 'Add Colour Clip' in the Project Bin, I often want to replicate an existing background colour of another element in my edit. 
So from the colour dropdown, I choose "custom..."
In the dialogue box that appears, I choose 'pick screen colour'
I can then pick a colour from the clip in the project monitor - but everything else has been darkened slightly to highlight the colour dialogue box.

Actual Results:  
The resulting colour clip is much darker than the colour I was trying to sample.

Expected Results:  
Darkening the background in order to highlight the dialogue box is useful in all other situations, so maybe the solution should be that the background stays darkened until the 'pick screen colour" button is pressed - from this moment until a colour is selected, everything would be shown at normal brightness levels, and then once selected, the background would be darkened again.


Kdenlive version 16.07.70 - I'm using the kdenlive-testing ppa on kubuntu 15.10.

Comment 1 Jean-Baptiste Mardelle 2016-04-20 21:08:40 UTC

The color clip creation dialog in clipcreationdialog.cpp

void ClipCreationDialog::createColorClip(KdenliveDoc *doc, QStringList groupInfo, Bin *bin)
{
}

needs to be made non modal so that it does not obscure the main window

Comment 2 farid 2016-10-05 02:45:10 UTC

I am using 16.08.1 and Gnome and don't get the option to "pick screen color". Kdenlive uses a Gnome interface color window instead.

Comment 3 emohr 2018-10-20 12:28:40 UTC

Should be fixed with Kdenlive version 17.04