Bug 361770

Summary:	Missing F_ADD_SEALS
Product:	[Developer tools] valgrind	Reporter:	Marc-Andre Lureau <marcandre.lureau>
Component:	general	Assignee:	Julian Seward <jseward>
Status:	RESOLVED FIXED
Severity:	normal	CC:	desrt, mark, pjfloyd
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	[PATCH] Linux: Add wrapper for fcntl(F_{GET,ADD}_SEALS)

Description Marc-Andre Lureau 2016-04-14 15:52:38 UTC

valgrind crashes on linux fcntl(F_ADD_SEALS,..)

valgrind: m_syswrap/syswrap-linux.c:5416 (vgSysWrap_linux_sys_fcntl_before): Assertion 'Unimplemented functionality' failed.


thanks

Reproducible: Always

Comment 1 Julian Seward 2017-05-08 13:49:00 UTC

It would help if you had a test case for this.

Comment 2 Allison Karlitskaya 2020-10-13 11:17:54 UTC

Created attachment 132318 [details]
[PATCH] Linux: Add wrapper for fcntl(F_{GET,ADD}_SEALS)

Add also a testcase to memcheck/tests/linux, enabled according to a new
check for memfd_create() in configure.ac.

Comment 3 Allison Karlitskaya 2020-11-11 08:59:41 UTC

ping?

Comment 4 Allison Karlitskaya 2021-01-08 14:45:22 UTC

ping again?

Comment 5 Mark Wielaard 2021-02-20 20:31:54 UTC

Sorry this took so long. Especially since the patch was perfect.
Pushed as:

commit dec30506534c0c1bb0e77e62275e697b041e3c3a
Author: Allison Karlitskaya <allison.karlitskaya@redhat.com>
Date:   Tue Oct 13 13:17:11 2020 +0200

    Linux: Add wrapper for fcntl(F_{GET,ADD}_SEALS)
    
    Add also a testcase to memcheck/tests/linux, enabled according to a new
    check for memfd_create() in configure.ac.
    
    https://bugs.kde.org/show_bug.cgi?id=361770