Bug 361727

Summary:	Baloo crash - epub file
Product:	[Frameworks and Libraries] frameworks-baloo	Reporter:	Alan Aversa <aversa>
Component:	Baloo File Daemon	Assignee:	Christoph Cullmann <christoph>
Status:	RESOLVED FIXED
Severity:	crash	CC:	aspotashev, christoph, cunio, pinak.ahuja
Priority:	NOR	Keywords:	drkonqi
Version:	5.20.0
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:	http://commits.kde.org/kfilemetadata/47f6e57b2fa3768feb4f1f4a2cd3ce46660d90f2	Version Fixed In:
Sentry Crash Report:

Description Alan Aversa 2016-04-13 17:11:09 UTC

Application: baloo_file_extractor (5.20.0)

Qt Version: 5.5.1
Operating System: Linux 4.4.6 x86_64
Distribution (Platform): Slackware Packages

-- Information about the crash:
- What I was doing when the application crashed:
KDE finished loading, and then Baloo crashed. Baloo hasn't been working properly for me with the recent KDE versions; I'm thinking it might have to do with old conf file(s) conflicting with the new version.

-- Backtrace:
Application: Baloo File Extractor (baloo_file_extractor), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f7a08a127c0 (LWP 3795))]

Thread 2 (Thread 0x7f79fa99e700 (LWP 3796)):
#0  0x00007f7a04f8430d in poll () at /lib64/libc.so.6
#1  0x00007f79ffb76102 in  () at /usr/lib64/libxcb.so.1
#2  0x00007f79ffb77c8f in xcb_wait_for_event () at /usr/lib64/libxcb.so.1
#3  0x00007f79fcbf94b9 in  () at /usr/lib64/libQt5XcbQpa.so.5
#4  0x00007f7a05b8cf3f in  () at /usr/lib64/libQt5Core.so.5
#5  0x00007f7a03a57684 in start_thread () at /lib64/libpthread.so.0
#6  0x00007f7a04f8fefd in clone () at /lib64/libc.so.6

Thread 1 (Thread 0x7f7a08a127c0 (LWP 3795)):
[KCrash Handler]
#6  0x00007f79f8f2e932 in _opf_label_get_by_lang () at /usr/lib64/libepub.so.0
#7  0x00007f79f8f2b509 in epub_tit_next () at /usr/lib64/libepub.so.0
#8  0x00007f79f91360e4 in  () at /usr/lib64/qt5/plugins/kf5/kfilemetadata/kfilemetadata_epubextractor.so
#9  0x0000000000409318 in  ()
#10 0x000000000040999f in  ()
#11 0x00007f7a05d96648 in  () at /usr/lib64/libQt5Core.so.5
#12 0x00007f7a05d8af2b in QObject::event(QEvent*) () at /usr/lib64/libQt5Core.so.5
#13 0x00007f7a06a6f11c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#14 0x00007f7a06a74236 in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#15 0x00007f7a05d5d3f3 in QCoreApplication::notifyInternal(QObject*, QEvent*) () at /usr/lib64/libQt5Core.so.5
#16 0x00007f7a05dafacd in QTimerInfoList::activateTimers() () at /usr/lib64/libQt5Core.so.5
#17 0x00007f7a05db0019 in  () at /usr/lib64/libQt5Core.so.5
#18 0x00007f7a03309787 in g_main_context_dispatch () at /usr/lib64/libglib-2.0.so.0
#19 0x00007f7a033099b8 in  () at /usr/lib64/libglib-2.0.so.0
#20 0x00007f7a03309a5c in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0
#21 0x00007f7a05db0c1f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#22 0x00007f7a05d5af5a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#23 0x00007f7a05d62aed in QCoreApplication::exec() () at /usr/lib64/libQt5Core.so.5
#24 0x000000000040839c in  ()
#25 0x00007f7a04ea97d0 in __libc_start_main () at /lib64/libc.so.6
#26 0x0000000000408459 in _start ()

Reported using DrKonqi

Comment 1 Christoph Cullmann 2016-09-11 11:25:54 UTC

*** Bug 363299 has been marked as a duplicate of this bug. ***

Comment 2 Christoph Cullmann 2016-09-11 11:26:16 UTC

*** Bug 360625 has been marked as a duplicate of this bug. ***

Comment 3 Christoph Cullmann 2016-09-11 12:52:03 UTC

Potential fix there

https://git.reviewboard.kde.org/r/128888/

Comment 4 Christoph Cullmann 2016-09-11 12:58:07 UTC

*** Bug 352325 has been marked as a duplicate of this bug. ***

Comment 5 Christoph Cullmann 2016-09-11 17:17:38 UTC

Git commit 47f6e57b2fa3768feb4f1f4a2cd3ce46660d90f2 by Christoph Cullmann.
Committed on 11/09/2016 at 17:14.
Pushed by cullmann into branch 'master'.

Improve epub extractor, less segfaults

Improve epub extractor:

1) check for more nullpointers (e.g. data can be null for some fields, iterators, ...)
2) actually close the epub file again at all
3) iterator seems to handle clink as stated in docs, fix double free

e.g. see bug 361727
could be the double freed clink in the last iterator
REVIEW: 128888

M  +47   -42   src/extractors/epubextractor.cpp

http://commits.kde.org/kfilemetadata/47f6e57b2fa3768feb4f1f4a2cd3ce46660d90f2