Bug 361721

Summary:	various issues with small grid sizes
Product:	[Applications] krita	Reporter:	Alexander Koppe <koppe>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version First Reported In:	3.0 Alpha
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/e6c23b2765dd007b7b10ec480036d657d443d159	Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Koppe 2016-04-13 13:49:15 UTC

1) it is currently not possible to set the grid size to anything smaller than 2x2 px,
for pixel art a grid of 1x1 pixels would be usefull

2 )when the grid is set to 2x2 pixels, it sometimes has 2x1 or 1x2 cells for some rows

Reproducible: Sometimes

Steps to Reproduce:
1. try to create a grid of 1x1 px (currently not possible)
2. create a 2x2 px grid
3. experience strange behaviour (sometimes)

Comment 1 Halla Rempt 2016-04-13 13:53:17 UTC

I can confirm the issue.

Comment 2 Dmitry Kazakov 2016-04-15 18:22:49 UTC

Git commit e6c23b2765dd007b7b10ec480036d657d443d159 by Dmitry Kazakov.
Committed on 15/04/2016 at 18:22.
Pushed by dkazakov into branch 'master'.

Fix wrong values of Grid spacing when changing the spin box

1) KisAspectRatioLocker blocks the signal of the second spinbox,
   but the configuration should be updated only when both the
   spinboxes are updated. Therefore a new signal in KisAspectRatioLocker
   has been implemented, which notifies the receivers that both boxes
   are ready.

2) Allow 1 px grid :)

Fixes T2245

M  +5    -0    libs/ui/kis_aspect_ratio_locker.cpp
M  +4    -0    libs/ui/kis_aspect_ratio_locker.h
M  +6    -8    plugins/dockers/griddocker/grid_config_widget.cpp
M  +8    -8    plugins/dockers/griddocker/grid_config_widget.ui

http://commits.kde.org/krita/e6c23b2765dd007b7b10ec480036d657d443d159