Bug 361706

Summary: [NTRIG] Krita does not recognize a right click performed by Surface Pen while on canvas
Product: [Applications] krita Reporter: PFM <paul>
Component: Tablets (tablet issues are only very rarely bugs in Krita!)Assignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: alvin, halla, herrkjeldsen, hhielscher, miabraha, osxyz, scottpetrovic
Priority: NOR    
Version: 2.9   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In: 3.3.0-rc.1
Sentry Crash Report:

Description PFM 2016-04-13 07:33:34 UTC 
By default, the side button of the Surface Pen performs a right click which should open the popup palette while on canvas. Instead it performs the operation of the current brush. While not on canvas, right clicking with the pen works fine.

Reproducible: Always

Steps to Reproduce:
1. Use Surface Pen to perform a right click
2. See that it paints instead of opening the popup palette
3. Profit

Actual Results:  
Krita uses the equipped brush

Expected Results:  
Krita should have opened the popup palette

PC: Surface Pro 4, all drivers up to date
Surface Pen came with Surface Pro 4
Comment 1 Halla Rempt 2016-04-15 06:16:05 UTC 
Hi,

At one point we had this sort of working, but a bunch of updates broke that again. The issue is that the Microsoft N-trig wintab driver just doesn't conform to the standard and we don't know exactly what to do with it.
Comment 2 eliotJ 2016-05-11 21:41:21 UTC 
Hi

Does it's also exist in Krita v2.9.11 or does it's a regression in v3.0 ?
Comment 3 Halla Rempt 2016-05-25 12:43:07 UTC 
It's not a regression, this never really worked. Only in 3.0 for a short while -- not sure what happened then, Michael Abrahams was working on it.
Comment 4 eliotJ 2016-05-26 13:08:19 UTC 
ok. thx
Comment 5 Michael 2016-05-28 21:18:22 UTC 
I don't think I ever got the right click working, I focused on getting the eraser going.
Comment 6 Scott Petrovic 2016-06-07 14:23:59 UTC 
This is a more of a problem with Microsoft's pen than Krita. It is called a "right-click" button, but it oddly doesn't do a right-click event. It doesn't work on the canvas because Krita has to use the mouse down behavior - which doesn't work with how Microsoft is using their "press and hold to right click" behavior. You are correct that this press and hold behavior works on the user interface, but not on the canvas.

The Surface Pro pen side button doesn't have a valid state that Qt can pick up, so there is not much that can be done on our side. 

If Microsoft could add a feature to actually make their "right click button" right-click, that would solve the issue. They started to add some configuration for their pen, so hopefully they can add that soon.

I have a Surface Pro 4 and have tested this quite a bit. Krita needs that down state while drawing on the canvas, so we would have to add custom logic specifically for the Surface Pro if we would want this to work.
Comment 7 Michael 2016-06-07 17:37:39 UTC 
I think this is Microsoft's way of saying they really want everyone to implement their Ink API.
Comment 8 Marcus Kjeldsen 2016-06-14 19:29:38 UTC 
Silly Microsoft!
Comment 9 Alvin Wong 2017-09-21 09:49:47 UTC 
Using Windows Ink through Pointer Input messages on Windows 8 or above is supported in 3.3.0-rc.1 (though not enabled by default): https://krita.org/en/item/krita-3-3-0-first-release-candidate/

It should work better for N-Trig Surface devices than WinTab, and this issue should be fixed with it.