Bug 361458

Summary: BQM Lens Correction tool does not work
Product: [Applications] digikam Reporter: nate <n8bartnick>
Component: Plugin-Bqm-LensCorrectionAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 4.14.0   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/2cb1f3b9d1c0d37513a8f55653572dc5ea832777 Version Fixed In: 5.0.0
Sentry Crash Report:

Description nate 2016-04-06 15:24:42 UTC 
BQM Lens Correction tool does not work, but Lens Correction tool works when not used in batch mode. I have tried BQM Lens Correction tool in Mint KDE (Ubuntu 14.04), Lubuntu 14.04, and have tried to use BQM Lens Correction tool in Digikam 4.14.0 and it still does not work. When processing an image in BQM Lens Correction tool no changes are made and I do not get an indication of a failure. 

Reproducible: Always

Steps to Reproduce:
1.add image(s) to Batch Queue Manager (new or current queue 
2.assign tools: Lens Auto Correction 
3.uncheck Use Metadata
4. Make: Fujifilm (I have tried other models and lens and nothing happens too)
5. Model: FinePix x100
6. X100 & compatibles (Standard) + WCL-X100 (I made this setting it works in non batch mode)
7. check distortion and Geometry
8. Add Assigned tool: convert to JPEG (or any other type)
9. Click Run

Actual Results:  
no lens distortion changes are made to the image

Expected Results:  
lens distortion changes make like when using in non batch mode
Comment 1 caulier.gilles 2016-04-06 15:42:27 UTC 
What did you see on the console when you run BQM with this tool ?

Gilles Caulier
Comment 2 Maik Qualmann 2016-04-06 17:20:59 UTC 
Git commit 2cb1f3b9d1c0d37513a8f55653572dc5ea832777 by Maik Qualmann.
Committed on 06/04/2016 at 17:19.
Pushed by mqualmann into branch 'master'.

fix manual mode from Lens Correction tool in BQM
FIXED-IN: 5.0.0

M  +3    -3    utilities/queuemanager/basetools/enhance/lensautofix.cpp

http://commits.kde.org/digikam/2cb1f3b9d1c0d37513a8f55653572dc5ea832777
Comment 3 Maik Qualmann 2016-04-06 19:25:22 UTC 
Git commit 676b290423d46a9cc6dd11b577b6c7af908ad93f by Maik Qualmann.
Committed on 06/04/2016 at 19:24.
Pushed by mqualmann into branch 'master'.

fix restore filter settings from Lens Correction tool in BQM

M  +10   -0    libs/dimg/filters/lens/lensfunsettings.cpp
M  +1    -0    libs/dimg/filters/lens/lensfunsettings.h
M  +31   -19   utilities/queuemanager/basetools/enhance/lensautofix.cpp

http://commits.kde.org/digikam/676b290423d46a9cc6dd11b577b6c7af908ad93f