Summary: | Creates nameless subalbums and corrupts album hierarchy | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | kramski |
Component: | Database-Albums | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | kramski, metzpinguin, post |
Priority: | NOR | ||
Version: | 5.0.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/digikam/13f08a6e19808cdb047511322c533e1d3a706ff2 | Version Fixed In: | 5.0.0 |
Attachments: |
Screenshot 1: Healthy album before import
Screenshot 2: Import Window Screenshot 3: Album after import Console output of digikam showing two testcases testDebug.patch Console output of small testcase with debug patch enabled mkdirTest.patch Console output after mkdirTest.patch test2Debug.patch CoreDBUrl.patch |
Description
kramski
2016-04-03 11:46:58 UTC
Created attachment 98212 [details]
Screenshot 1: Healthy album before import
Created attachment 98213 [details]
Screenshot 2: Import Window
Created attachment 98214 [details]
Screenshot 3: Album after import
Created attachment 98215 [details]
Console output of digikam showing two testcases
I can not reproduce this problem here (tested with SQLite and internal MySQL DB). I see no problem in this source code. The same problem, If you manually create a album (right-click album tree -> New...)? Can you test it with completely locally album and a SQLite DB? Maik Thanks Maik, with your help I was able to find a much simpler testcase. I can reproduce this with SQLite and a local album and even if I just manually create a new album with right-click, so this is not really an import issue. However, this seems to require a particular folder structure. To reproduce: 1. Create a file system folder named "Test-local3". Inside "Test-local3" create an empty folder named "Folder". Inside "Folder" create a folder named "Subfolder" and put an image there. 2. Create a new Digikam album for "Test-local3" with "Settings / Digikam einrichten (configure?) / Collections / Add [local] Collection" 3. Right-click on "Folder" and create a new album "NewSubfolder". 4. See a nameless album and duplicate albums appear... Also with this test case is not to reproduce the problem here. There must be another cause. In principle, it is impossible that digiKam folder with slashes created at the end. Could you try a patch? I would insert more debug messages. Maik Ok, sure. Created attachment 98247 [details]
testDebug.patch
Please try this patch, create a wrong album folder and upload the console output.
In the "core" folder:
patch -p0 < testDebug.patch
Maik
Created attachment 98248 [details]
Console output of small testcase with debug patch enabled
Thanks. Here is the requested log of a small testcase (new album via right click), reproduced on a different (but very similar) machine.
Heinz
Created attachment 98257 [details]
mkdirTest.patch
This is not a productive patch, it is only a test. Please look whether the issue is resolved.
Maik
Created attachment 98261 [details]
Console output after mkdirTest.patch
Sorry, no progress. issue still exists.
Heinz
Created attachment 98262 [details]
test2Debug.patch
Strange problem, please give me the ouput from this patch. What for a file system you use?
Maik
I'm setting up a new family picture server via NFS V3, server is BTRFS. This used to work approx. 4 weeks ago, don't know which update broke it. Latests tests were done on a laptop on ext4 (DB and picture folders). Can also reproduce on XFS and on Samba mounts, so I don't think it's FS related. Latest output: [...] digikam.general: Cancel Main Thread digikam.general: One job is done digikam.geoiface: ---- ------------------------>AlbumManager::createPAlbum--1--> "New Album" ------------------------>AlbumManager::createPAlbum--2--> (".", "..", "Folder") ------------------------>AlbumManager::createPAlbum--3--> QUrl("file:///mufu/transfer/test-local5/Folder/New Album") digikam.general: QFileSystemWatcher detected change at "/mufu/transfer/test-local5/Folder//" digikam.general: Detected change, triggering rescan of directory "/mufu/transfer/test-local5/Folder//" ------------------------>AlbumManager::createPAlbum--4--> (".", "..", "Folder") digikam.database: Starting scan! digikam.dimg: "/mufu/transfer/test-local5/Folder//Subfolder/user-manager.png" : PNG file identified digikam.database: Adding new item "/mufu/transfer/test-local5/Folder//Subfolder/user-manager.png" digikam.database: Recognized "/mufu/transfer/test-local5/Folder//Subfolder/user-manager.png" as identical to item 11 digikam.database: Scanning took 1 ms digikam.database: Finishing took 5 ms digikam.geoiface: ---- digikam.general: Cancel Main Thread [...] Heinz (afk for today) Created attachment 98268 [details]
CoreDBUrl.patch
Please try this patch for testing. What Qt version you use?
Maik
Great, that fixed it! Thanks a lot for your help! Versions: KDE Frameworks 5.20.0, Qt 5.6.0, kernel 4.4.5-1-ARCH x86_64 Output: [...] digikam.geoiface: ---- ------------------------>AlbumManager::createPAlbum--1--> "New Album" digikam.coredb: CoreDbUrl::fromAlbumAndName : "digikamalbums:/Folder/?albumRoot=/mufu/transfer/test-local5&albumRootId=1&databaseType=QSQLITE&databaseNameCore=/mufu/transfer/digikam/digikam4.db&databaseNameThumbnails=/mufu/transfer/digikam/thumbnails-digikam.db&databaseNameFace=/mufu/transfer/digikam/recognition.db&connectOptions=&hostName=&userName=&password=" ------------------------>AlbumManager::createPAlbum--2--> (".", "..", "Folder") ------------------------>AlbumManager::createPAlbum--3--> QUrl("file:///mufu/transfer/test-local5/Folder/New Album") digikam.general: QFileSystemWatcher detected change at "/mufu/transfer/test-local5/Folder/" digikam.general: Detected change, triggering rescan of directory "/mufu/transfer/test-local5/Folder/" ------------------------>AlbumManager::createPAlbum--4--> (".", "..", "Folder") digikam.coredb: CoreDbUrl::fromAlbumAndName : "digikamalbums:/Folder/New Album/?albumRoot=/mufu/transfer/test-local5&albumRootId=1&databaseType=QSQLITE&databaseNameCore=/mufu/transfer/digikam/digikam4.db&databaseNameThumbnails=/mufu/transfer/digikam/thumbnails-digikam.db&databaseNameFace=/mufu/transfer/digikam/recognition.db&connectOptions=&hostName=&userName=&password=" digikam.database: Starting scan! digikam.geoiface: ---- digikam.geoiface: ---- digikam.coredb: CoreDbUrl::fromAlbumAndName : "digikamalbums:/Folder/New Album/?albumRoot=/mufu/transfer/test-local5&albumRootId=1&databaseType=QSQLITE&databaseNameCore=/mufu/transfer/digikam/digikam4.db&databaseNameThumbnails=/mufu/transfer/digikam/thumbnails-digikam.db&databaseNameFace=/mufu/transfer/digikam/recognition.db&connectOptions=&hostName=&userName=&password=" digikam.general: Using 4 CPU core to run threads [...] Should I adjust bug title and component to better reflect the facts? Thanks again and regards, Heinz Git commit 13f08a6e19808cdb047511322c533e1d3a706ff2 by Maik Qualmann. Committed on 06/04/2016 at 19:39. Pushed by mqualmann into branch 'master'. fix double slashes in QUrl with Qt-5.6.0 FIXED-IN: 5.0.0 M +2 -1 NEWS M +1 -4 libs/database/coredb/coredburl.cpp http://commits.kde.org/digikam/13f08a6e19808cdb047511322c533e1d3a706ff2 Thank you for testing the patches. Maik *** Bug 362268 has been marked as a duplicate of this bug. *** |