| Summary: | Double click to maximize does not work in some situations | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Bernd Steinhauser <linux> |
| Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdebugs, martin, mitrax, plusfabi |
| Priority: | NOR | ||
| Version First Reported In: | 5.6.1 | ||
| Target Milestone: | --- | ||
| Platform: | Exherbo | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwin/152be60cc04f81fb54fdbe0afec41470aa188d54 | Version Fixed In: | 5.10.3 |
| Sentry Crash Report: | |||
|
Description
Bernd Steinhauser
2016-03-31 17:50:55 UTC
Forgot to mention: I ran kwin at commit id ed1d32288b50647469fb0e000f21b849e286ca36 to test this. When using kwin at 95cbd7c1b3cdbe81fdee1682049bd08ab7fe99fb (parent), I cannot reproduce it at all (or at least the above does not work when trying about 10 times). Also present in 5.6.1. Looking at the patch, I seem to have messed it on resolving a merge conflict (wrong indentention/linebreak and it actually doesn't make any sense the way it is)
@Martin, better don't wait for me to push this.
diff --git a/abstract_client.cpp b/abstract_client.cpp
index b323030..aab929f 100644
--- a/abstract_client.cpp
+++ b/abstract_client.cpp
@@ -1406,14 +1406,13 @@ bool AbstractClient::processDecorationButtonPress(QMouseEvent *event, bool ignor
const quint64 interval = m_decoration.doubleClickTimer.elapsed();
m_decoration.doubleClickTimer.invalidate();
if (interval > QGuiApplication::styleHints()->mouseDoubleClickInterval()) {
- m_decoration.doubleClickTimer.invalidate(); // expired -> new first click and pot. init
+ m_decoration.doubleClickTimer.start(); // expired -> new first click and pot. init
} else {
Workspace::self()->performWindowOperation(this, options->operationTitlebarDblClick());
dontMoveResize();
return false;
}
- }
- else {
+ } else {
m_decoration.doubleClickTimer.start(); // new first click and pot. init, could be invalidated by release - see below
}
}
That fixes the problem, thanks. *** Bug 361480 has been marked as a duplicate of this bug. *** A similar scenario, KDE 5.6.4 (Archlinux). Double click titlebar to lower, is configured, i find that: - Triple click is needed in 5.6.4 when just entering the window and not manipulating it beforehand. - Not in 5.5.5, so a regression. - Funnily double click to lower works- when the window is first dragged or has it’s border clicked once (not titlebar). was that integrated? At least on my system (5.7.x) I can't reproduce the bug anymore. on my system (5.7.3) the bug is still there (but i'm using "to minimize" by double click) so maybe its a different case $ kwin_x11 --version kwin 5.7.3 Doubleclick to lower, bug still there, more often than not -tripleclick is needed. $ kwin_x11 --version kwin 5.7.5 Easiest way to replicate the issue of not detecting double click: 1. Setup Double-click: to "Lower" under "Titlebar" and Left button: to "Raise" "Active" under "Titlebar & Frame" 2. Have a window with visible titlebar below another window. 3. Click the titlebar to bring it to front, double click it to bring it lower, this may actually work the first time. 4. Repeat step 3 to notice. :) $ kwin_x11 --version kwin 5.8.0 Bug is still there. I recommend my previous post for the easiest way to reproduce it. can still reproduce it like explained in comment#0 with kwin 5.8.3 (openSuse 42.2) I have configured to minimize by double click. Decoration is Breeze. The issue is still here. ENVIRONMENT: Platform: KDE Neon KDE Plasma Version: 5.10.2 KDE Framework Version: 5.35.0 Qt Version: 5.9.0 Git commit 152be60cc04f81fb54fdbe0afec41470aa188d54 by Martin Flöser. Committed on 22/06/2017 at 05:07. Pushed by graesslin into branch 'Plasma/5.10'. Fix double click on window deco if tripple clicked Patch by Thomas Lübking which got lost in bugs.kde.org. FIXED-IN: 5.10.3 M +1 -1 abstract_client.cpp https://commits.kde.org/kwin/152be60cc04f81fb54fdbe0afec41470aa188d54 |