Summary: | little box around filenames is missing with Plasma 5.6 | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | FabiB <plusfabi> |
Component: | Folder | Assignee: | Eike Hein <hein> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, nate, plasma-bugs, samrog131 |
Priority: | NOR | Keywords: | triaged |
Version: | 5.6.1 | Flags: | hein:
Usability+
hein: VisualDesign+ |
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-desktop/10278e79f11677bd59f7d554eb8e18e580686082 | Version Fixed In: | 5.12.8 |
Attachments: |
left 5.5, right 5.6 folderview-desktop
bad readability on 4 backgrounds Tweaked shadows |
Description
FabiB
2016-03-31 11:29:43 UTC
Created attachment 98169 [details]
left 5.5, right 5.6 folderview-desktop
Can you show an example of a problematic background? We changed it after testing with many different kinds of backgrounds, and the shadow version was universally preferred so far. Created attachment 98184 [details]
bad readability on 4 backgrounds
Mostly black+white things. so many "normal" anime/manga backgrounds gives us hard readability on many screens.
i'm also a little shoked that you even tried this... after all this translucenty, blurry things on windows and KDE Plamsa 1 that makes it hard to read text somewhere. after all Plasma distros are choosing a more "solid" dark plasma theme instead of the translucent white(exept for KaOS, who choose a solid, white one and some who only ship vanilla packages). it should be clear that nobody wants this, but a always good readable thing like it finally was with the last versions of kde plasma
:(
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! issue reported here is still valid for plasma 5.14.2. Meanwhile the users can add the 'boxes' back. An example: https://forum.kde.org/viewtopic.php?f=289&t=131951&p=407379#p407379 I also would prefer not to go back to the old style for simple aesthetic reasons, though I acknowledge that it was probably better with busy backgrounds. Maybe we should make the shadow a tad bigger? Created attachment 116378 [details]
Tweaked shadows
Tweaking the shadows is thankfully pretty trivial (you can do so yourself by editing /usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml, see line 411).
Here's a tweak (radius 12, spread 0.3) on top of my favorite torture test background. Seems a bit better; would that suffice?
Here's a speculative patch: https://phabricator.kde.org/D16968 Git commit 10278e79f11677bd59f7d554eb8e18e580686082 by Nate Graham. Committed on 27/11/2018 at 14:16. Pushed by ngraham into branch 'Plasma/5.12'. [Folder View] improve label contrast against challenging backgrounds Summary: Currently the shadow behind Folder View items' labels is very subtle. This leads to poor contrast against wallpapers that are light-colored, visually busy, or both. This patch attempts to improve the situation by tightening up the shadow so that it looks more like a subtle, tasteful outline. FIXED-IN: 5.12.8 Test Plan: Folder View items against various wallpapers: {F6439459, size="full"} {F6439458, size="full"} {F6439463, size="full"} {F6439457, size="full"} {F6439456, size="full"} {F6439455, size="full"} {F6439454, size="full"} {F6439453, size="full"} {F6439452, size="full"} {F6439451, size="full"} Folder View items against the default wallpaper: {F6439449, size="full"} Reviewers: #plasma, hein, #vdg Reviewed By: #plasma, hein Subscribers: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D16968 M +5 -5 containments/desktop/package/contents/ui/FolderItemDelegate.qml https://commits.kde.org/plasma-desktop/10278e79f11677bd59f7d554eb8e18e580686082 |