Bug 361220

Summary:	Undefined gradients in 24*24 SVG Breeze icons, cleanup needed.
Product:	[Plasma] Breeze	Reporter:	kkoksvik
Component:	Icons	Assignee:	visual-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	kainz.a
Priority:	NOR
Version First Reported In:	5.6.1
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
URL:	http://forum.freecadweb.org/viewtopic.php?f=3&t=14716
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Search result of first gradient in list on 24*24 icon folder

Description kkoksvik 2016-03-31 07:38:32 UTC

When running FreeCAD or Kdevelop using 24*24 Breeze iconsize, the following errormessages are displayed on std output, when the icons are accessed.

Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548

My investigation shows me that there are undefined gradients and unused geometry in some SVG icon files.

Reproducible: Always

Steps to Reproduce:
1. Start FreeCAD or Kdevelop in konsole and watch for error output
2.
3.

Actual Results:  
Error output
Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548


Expected Results:  
No errors

Comment 1 andreas 2016-03-31 09:14:09 UTC

Hi

I'm not sure what happens and maybe you can add the icon names with the gradient's but
1. 24px icons are ONLY for GTK applications
2. I start already a svg cleaning session for all files to reduce the file size and to remove unused code. but this will take a while cause I have to do it manually to guaranty the stylesheed stuff. If you would like to help, you are very welcome.

Comment 2 kkoksvik 2016-03-31 17:13:35 UTC

Created attachment 98177 [details]
Search result of first gradient in list on 24*24 icon folder

Comment 3 kkoksvik 2016-03-31 17:16:19 UTC

Hi,
Glad to hear that cleanup is ongoing, I know there are some software on git hub that can automate the process. 

https://github.com/RazrFalcon/SVGCleaner

But I do not know how these svg Icons work internally, and what kind of functionality of the svg format you are using.

 From what i can tell if the gradient is only found one time in the svg file, the gradient is defined (i guess this is no problem, other than file size) or used and not defined witch makes qt generate errors.

Attached is the result of a search for the first gradient in the list.

Comment 4 kkoksvik 2016-04-21 11:58:33 UTC

It seams like this has been solved. I can not seam to find the change that fixed it. But I do not see the problem anymore when using FreeCAD

Thanks:-)

Comment 5 andreas 2016-04-21 13:00:59 UTC

you are welcome, I fixed the 16px, 22px action icons and for 24px I'm working on it but it took some time. Nice that you can see the improvement