| Summary: | Battery monitor shows 0:60 instead of 1:00 for remaining battery | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kcoreaddons | Reporter: | Malte Eggers <malte.e> |
| Component: | general | Assignee: | Michael Pyne <mpyne> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | andyspiros, kde, kde, kdelibs-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kcoreaddons/13675d6ab695ba3d1e621ae5493f66ee25e5091d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot showing the bug | ||
|
Description
Malte Eggers
2016-03-18 01:54:27 UTC
Created attachment 98162 [details]
Screenshot showing the bug
I noticed the bug today and made a screenshot. The message "0:60 remaining" is very confusing.
(In reply to Andrea Arteaga from comment #1) > Created attachment 98162 [details] > Screenshot showing the bug > > I noticed the bug today and made a screenshot. The message "0:60 remaining" > is very confusing. By the way, I'm on Fedora 23. PowerDevil shows "Revision KDE 4.11 (2013-08-18)". I have Plasma 5.5.5. It's using kcoreaddons (iirc) to format the duration. Perhaps some rounding error there? Also, I don't consider running Plasma 5 with PowerDevil 4 a supported setup. I was just reporting what I found on the help page I have on my system. After a closer look I realized I actually have PowerDevil 5.5.5. I probably landed on an outdated page... I've seen the same on openSUSE. Git commit 13675d6ab695ba3d1e621ae5493f66ee25e5091d by David Edmundson. Committed on 06/07/2017 at 20:16. Pushed by davidedmundson into branch 'master'. Fix display of formatDuration with rounding. Summary: When showing the time (1 hour 59.5 minutes) with seconds hidden we want to show "2 hours 0 minutes" not "1 hour 60 minutes". This is fixed by performing the rounding before we split the number of miliseconds into component parts, rather than splitting and then rounding. Related: bug 382069 Test Plan: Updated unit test Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D6537 M +20 -0 autotests/kformattest.cpp M +14 -8 src/lib/util/kformatprivate.cpp https://commits.kde.org/kcoreaddons/13675d6ab695ba3d1e621ae5493f66ee25e5091d |