Bug 360664

Summary:	Oxygen5 Icon Theme erroneously inherits Breeze not hicolor
Product:	[Plasma] Oxygen	Reporter:	Paul <pip.kde>
Component:	icons	Assignee:	pinheiro <nuno>
Status:	RESOLVED DOWNSTREAM
Severity:	normal	CC:	cameronpoe, cfeck, kdelibs-bugs, opensuse.lietuviu.kalba, wbauer1
Priority:	NOR
Version:	5.5.5
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screen-shot showing incorrect fallback to breeze

Description Paul 2016-03-17 14:19:10 UTC

KDE Frameworks 5.19.0
Plasma 5.5.5

oxygen5-icon-theme (48ecefb Tue, 15 Mar 2016 15:55:07 +0000)


The Oxygen Icon Theme (oxygen5-icon-theme) inherits icons from Breeze, not hicolor, even though "Inherits=hicolor" is set in the "index.theme"

I guess this is not a problem with the actual icon set, more the way the icon to be displayed is selected.

Taking just one example, "gparted"

These icons are available:

usr/share/icons/hicolor/16x16/apps/gparted.png
usr/share/icons/hicolor/22x22/apps/gparted.png
usr/share/icons/hicolor/24x24/apps/gparted.png
usr/share/icons/hicolor/32x32/apps/gparted.png
usr/share/icons/hicolor/48x48/apps/gparted.png
usr/share/icons/hicolor/scalable/apps/gparted.svg


The icon being used however is:
usr/share/icons/breeze/apps/48/gparted.svg
usr/share/icons/breeze-dark/apps/48/gparted.svg

as can be seen in the attached screenshot.

This is not restricted to "gparted". It appears that Breeze is being used as the fallback theme for any icon not found in Oxygen.

Comment 1 Paul 2016-03-17 14:20:17 UTC

Created attachment 97937 [details]
Screen-shot showing incorrect fallback to breeze

Comment 2 opensuse.lietuviu.kalba 2016-03-17 16:17:46 UTC

See more complains in https://bugs.kde.org/show_bug.cgi?id=360664

Comment 3 Paul 2016-03-17 18:08:07 UTC

(In reply to opensuse.lietuviu.kalba from comment #2)

A work-around for this which restores all oxygen/hicolor icons is to simply merge on a size for size basis, the icons from hicolor with those of oxygen.

Comment 4 opensuse.lietuviu.kalba 2016-03-17 18:37:06 UTC

I use simple solution – fully remove all Breze icons (as personally I much prefer Oxygen over Breze icons)

Comment 5 Wolfgang Bauer 2016-03-18 12:27:26 UTC

Apparently this was caused by the following commit:
https://quickgit.kde.org/?p=kiconthemes.git&a=commit&h=b544c17decc22685207ac11fbd95536e0d798650

It has been reverted in KDE, but it still was part of the openSUSE pacakges, where it has been removed now too.

Comment 6 Wolfgang Bauer 2016-03-18 12:54:06 UTC

*** Bug 356064 has been marked as a duplicate of this bug. ***

Comment 7 Wolfgang Bauer 2016-03-18 13:02:23 UTC

*** Bug 360569 has been marked as a duplicate of this bug. ***

Comment 8 cameronpoe 2016-04-09 09:56:40 UTC

(In reply to Wolfgang Bauer from comment #5)
> It has been reverted in KDE, but it still was part of the openSUSE pacakges,
> where it has been removed now too.

I have the newest openSUSE 42.1 and all updates installed, but I still see those breeze icons, so this bug is not fixed yet :(
I deleted ~./.cache/icon-cache.kcache, but it did not help.

Comment 9 Aleix Pol 2016-05-17 10:23:57 UTC

Git commit ad1ead84ee2c3a14363afdb048b3579f3d01fa18 by Aleix Pol.
Committed on 17/05/2016 at 10:23.
Pushed by apol into branch 'master'.

Don't make KIconThemes depend on Oxygen
Related: bug 336739
REVIEW: 127817

M  +0    -1    src/kiconloader.cpp
M  +2    -2    src/kicontheme.cpp

http://commits.kde.org/kiconthemes/ad1ead84ee2c3a14363afdb048b3579f3d01fa18