| Summary: | Mirror tool axis behaves as if it gets snapped, when you move it around canvas | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Raghavendra kamath <raghu> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, halla, scottpetrovic |
| Priority: | NOR | Keywords: | release_blocker |
| Version First Reported In: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/krita/3d152322866a64e757c1a664cc8eac41223f406a | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Raghavendra kamath
2016-03-16 11:42:36 UTC
Yeah, confirmed. It is really weird as well, because it doesn't actually snap(there's no snapping at all in the code), it just wobbles around awkwardly. https://phabricator.kde.org/T2298 Release blocker because regression. I looked at the code for this briefly to see if I could fix it ( I couldn't). The mirror tool has its own input handling with dragging and release events for the move handle -- which is the cause of the issue. The 'jittering' is because there are mouse events that fire along with tablet events in the code and report slightly different positions. This input problem is fixed in the regular kis_input_manager, but not handled correctly for this tool. There are a few other areas that have this custom input management, so we might need to think of a better way to organize it to prevent duplicate code. Git commit 3d152322866a64e757c1a664cc8eac41223f406a by Dmitry Kazakov. Committed on 29/04/2016 at 15:52. Pushed by dkazakov into branch 'master'. Fix jumping of the mirror axis handle The event filter should process only events that are targeted to the canvas itself. Other widgets are not interesting for us. Fixes T2298 M +19 -10 libs/ui/canvas/kis_mirror_axis.cpp http://commits.kde.org/krita/3d152322866a64e757c1a664cc8eac41223f406a |