Bug 360501

Summary:	Broken signal/slot connections
Product:	[Applications] umbrello	Reporter:	Ralf Habacker <ralf.habacker>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	CONFIRMED ---
Severity:	normal
Priority:	NOR
Version:	Git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Ralf Habacker 2016-03-14 07:47:42 UTC

While looking at review 127304 it turns out that umbrello source code contains some broken signal/slot connections (e.g. the mentioned slot method does not exist) which prevents a successful compile of the related patch. It is required to fix the broken connections.



Reproducible: Always

Comment 1 Ralf Habacker 2016-03-14 08:09:57 UTC

Git commit 6b847cd47dd970bef718383e9cd45be941bf7d83 by Ralf Habacker.
Committed on 14/03/2016 at 07:58.
Pushed by habacker into branch 'master'.

Fix 'Broken signal/slot connections'.

Remove connection to unavailable RefactoringAssistant::method().

M  +1    -1    umbrello/refactoring/refactoringassistant.cpp

http://commits.kde.org/umbrello/6b847cd47dd970bef718383e9cd45be941bf7d83

Comment 2 Ralf Habacker 2016-03-14 08:35:19 UTC

Git commit 47f5312c20b1a84fd70c860c29870ca00c5d6b0a by Ralf Habacker.
Committed on 14/03/2016 at 08:02.
Pushed by habacker into branch 'master'.

Fix 'Broken signal/slot connections'.

Remove parameters from RefactoringAssistant::objectModified() to make it connectable to signal UMLObject::modified().

M  +2    -4    umbrello/refactoring/refactoringassistant.cpp
M  +1    -1    umbrello/refactoring/refactoringassistant.h

http://commits.kde.org/umbrello/47f5312c20b1a84fd70c860c29870ca00c5d6b0a

Comment 3 Ralf Habacker 2016-03-19 20:17:23 UTC

Git commit b377f5ff2283e9bedf1628c7df74f07d23685930 by Ralf Habacker.
Committed on 16/03/2016 at 19:18.
Pushed by habacker into branch 'frameworks'.

Fix 'Broken signal/slot connections'.

Remove parameters from RefactoringAssistant::objectModified() to make it connectable to signal UMLObject::modified().

M  +2    -4    umbrello/refactoring/refactoringassistant.cpp
M  +1    -1    umbrello/refactoring/refactoringassistant.h

http://commits.kde.org/umbrello/b377f5ff2283e9bedf1628c7df74f07d23685930

Comment 4 Ralf Habacker 2016-03-19 20:17:23 UTC

Git commit 1ac7f3ed017c1b86a816af12d820cf676dd367d2 by Ralf Habacker.
Committed on 16/03/2016 at 19:18.
Pushed by habacker into branch 'frameworks'.

Fix 'Broken signal/slot connections'.

Remove connection to unavailable RefactoringAssistant::method().

M  +1    -1    umbrello/refactoring/refactoringassistant.cpp

http://commits.kde.org/umbrello/1ac7f3ed017c1b86a816af12d820cf676dd367d2

Comment 5 Lays Rodrigues 2016-10-27 12:07:57 UTC

Git commit 64e4f5d52dc42dd66455237bfb9513f7efebd1fd by Lays Rodrigues, on behalf of Ralf Habacker.
Committed on 27/10/2016 at 11:45.
Pushed by laysrodrigues into branch 'frameworks'.

Fix 'Broken signal/slot connections'.

Remove parameters from RefactoringAssistant::objectModified() to make it connectable to signal UMLObject::modified().

M  +0    -2    umbrello/refactoring/refactoringassistant.cpp

http://commits.kde.org/umbrello/64e4f5d52dc42dd66455237bfb9513f7efebd1fd