Bug 360434

Summary: Geolocation Editor messed up size and contents
Product: [Applications] digikam Reporter: Michal Sylwester <msylwester>
Component: Plugin-Generic-GeolocationEditAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version: 5.0.0   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/4ef2c460a33e5b65bb81bab6daf81445bb7d5733 Version Fixed In: 5.0.0
Sentry Crash Report:
Attachments: Too small initial size
Super high progress bar with doubled percentage value
Confusing icon

Description Michal Sylwester 2016-03-12 10:44:17 UTC 
After opening the Geolocation Editor it opens way too small and does not seem to remember it's size (this seems related to 357738). Additionally, the list of images being edited is gone. 

Reproducible: Always

Steps to Reproduce:
1. Select few images
2. Open Geolocation Editor:
 - window way too small, no list of images
 - correlation progress bar at the bottom extra high, percentage doubled 
 - there is a trash icon with a description "Display bookmarked positions on the map." which is confusing...

Actual Results:  
Opens very small, no list of images

Expected Results:  
Reasonable initial size, list of images, progress bar reasonable size

See screenshots
Comment 1 Michal Sylwester 2016-03-12 10:44:59 UTC 
Created attachment 97852 [details]
Too small initial size
Comment 2 Michal Sylwester 2016-03-12 10:45:44 UTC 
Created attachment 97853 [details]
Super high progress bar with doubled percentage value
Comment 3 Michal Sylwester 2016-03-12 10:46:17 UTC 
Created attachment 97854 [details]
Confusing icon
Comment 4 Maik Qualmann 2016-03-12 23:07:31 UTC 
Git commit df19f191662721cc5b610356da7aff697f3e69ae by Maik Qualmann.
Committed on 12/03/2016 at 23:05.
Pushed by mqualmann into branch 'master'.

fix initial size (now 800x600), bookmarks icon and progress bar size in the geolocation tool

M  +8    -7    utilities/geolocation/editor/dialog/geolocationedit.cpp

http://commits.kde.org/digikam/df19f191662721cc5b610356da7aff697f3e69ae
Comment 5 Maik Qualmann 2016-03-12 23:17:08 UTC 
The window size is not remembered, is not to reproduce here. Please test this commit, whether the images list can be seen now.

Maik
Comment 6 Maik Qualmann 2016-03-13 00:36:55 UTC 
Git commit 4ef2c460a33e5b65bb81bab6daf81445bb7d5733 by Maik Qualmann.
Committed on 13/03/2016 at 00:35.
Pushed by mqualmann into branch 'master'.

fix double percent view from progress bar

M  +4    -1    libs/progressmanager/statusprogressbar.cpp
M  +1    -1    tests/geolocation/geoiface/demo/mainwindow.cpp
M  +1    -1    utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp
M  +2    -2    utilities/geolocation/editor/dialog/geolocationedit.cpp
M  +1    -1    utilities/geolocation/editor/reversegeocoding/rgwidget.cpp

http://commits.kde.org/digikam/4ef2c460a33e5b65bb81bab6daf81445bb7d5733
Comment 7 caulier.gilles 2016-03-13 08:41:06 UTC 
tested. Problem is fixed with last commit....

Gilles Caulier
Comment 8 Michal Sylwester 2016-03-13 10:12:51 UTC 
Took me longer to compile it than it took you to fix it! Looks like everything I mentioned is fine now, thanks!