Bug 360330

Summary:	use the add and remove icons as dolphin did
Product:	[Plasma] plasmashell	Reporter:	andreas <kainz.a>
Component:	Folder	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, plasma-bugs
Priority:	NOR	Flags:	kainz.a: Usability+
Version:	5.5.3
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	select folder icon no big change only add an +

Description andreas 2016-03-09 19:12:41 UTC

you have really small overlay icons in the Icon HIG we define to have at least 6x6px overlay icons. I add two emblem icons for select folders (emblem-added) and remove (emblem-remove) please use this two icons in the plasmoid

Reproducible: Always

Comment 1 andreas 2016-03-09 19:47:49 UTC

Created attachment 97803 [details]
select folder icon

Comment 2 Kai Uwe Broulik 2016-03-09 19:53:02 UTC

We also need an icon for the "open this folder in a popup" icon as the currently half-filled circle is pretty non-descriptive

Comment 3 Eike Hein 2016-03-09 20:14:08 UTC

That's not how this works, sorry - the action overlay icons come from the widgets/action-overlays SVG in the Plasma theme, they're not part of the icon theme. The size is units.iconSizes.small, which seems appropriate for this use case (it's 16x16 on 1.0 scaling, 32x32 on 2.0, etc.).

Comment 4 andreas 2016-03-10 06:48:36 UTC

As the icon come from the plasma theme i will have a look there.

About the open the folder in a popup i will make a bug report, cause plasma is focused on office users and will make things done. The popup thing is only in the desktop layout. It is fancy but used anywhere else.

And the behaviour is different than in the icon view where you have the go up `folder` this is much more intuitive than the overlay stuff.

Comment 5 andreas 2016-03-10 11:39:47 UTC

(In reply to Eike Hein from comment #3)
> That's not how this works, sorry - the action overlay icons come from the
> widgets/action-overlays SVG in the Plasma theme, they're not part of the
> icon theme. The size is units.iconSizes.small, which seems appropriate for
> this use case (it's 16x16 on 1.0 scaling, 32x32 on 2.0, etc.).

are this icons only for the folder widget so I can change them to an + and something like an arrow? or are they used anywhere else and it would be a bad idea.

Comment 6 Eike Hein 2016-03-10 11:41:30 UTC

It's generic theming. The SVG contains elements with names like "remove", "add", "open" that the Folder View code uses, but it's available to all widgets.

Comment 7 andreas 2016-03-10 12:03:54 UTC

should or can I make them more less generic?

Comment 8 andreas 2016-03-10 12:04:19 UTC

Created attachment 97818 [details]
no big change only add an +

Comment 9 Kai Uwe Broulik 2017-08-25 14:25:17 UTC

I did exactly that to plasma-framework a while ago.