Bug 360329

Summary: Digikam 5 beta 4 build breaks
Product: [Applications] digikam Reporter: Philip Johnsson <philip.johnsson>
Component: Portability-CompilationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 5.0.0   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 5.0.0
Sentry Crash Report:

Description Philip Johnsson 2016-03-09 19:12:16 UTC
Digikam 5 beta4  breaks when trying to build. Digikam 5 beta 3 builds without problem.

/tmp/buildd/digikam5-5.0.0~beta4/core/libs/database/utils/dio.cpp: In member function 'void Digikam::DIO::slotResult()':
/tmp/buildd/digikam5-5.0.0~beta4/core/libs/database/utils/dio.cpp:359:50: error: 'class QList<QString>' has no member named 'join'
         QString errors = jobThread->errorsList().join(QLatin1String("\n"));

Building on Ubuntu 15.10 using QT 5.4.2 and KF5 5.15.0. Could these be too old to include string to the class? Could this be solved without bumping QT and/or KF5 version dependencies? 

Reproducible: Always



Expected Results:  
Successful build.

digikam5-5.0.0~beta4/core/utilities/metadataedit/xmp" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/metadataedit/exif" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/metadataedit/dialog" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/metadataedit/iptc" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/kdesupport/kipi" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/kdesupport/kio" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/kdesupport/ksane" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/kdesupport/kfilemetadata" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/kdesupport/akonadi" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/lighttable" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/items" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/views" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/widgets" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/dialogs" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/backend" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/main" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/importui/models" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/calendar/print" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/calendar/wizard" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/expoblending/blendingdlg" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/expoblending/importwizard" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/expoblending/manager" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/firstrun" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/utilities/assistants/common" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/databaseserver" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/imageplugins/color" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/imageplugins/filters" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/imageplugins/transform" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/imageplugins/enhance/hotpixels" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/imageplugins/enhance" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/imageplugins/decorate" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/showfoto/setup" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/showfoto/thumbbar" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/showfoto/main" -I"/tmp/buildd/digikam5-5.0.0~beta4/core/libs/jpegutils/libjpeg-84" -I"/tmp/buildd/digikam5-5.0.0~beta4/obj-x86_64-linux-gnu/core/app/utils" -I/usr/include/opencv -I/usr/include/KF5/Solid -I/usr/include/KF5 -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -I/usr/include/KF5/KWidgetsAddons -I/usr/include/x86_64-linux-gnu/qt5/QtWidgets -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/KF5/KConfigCore -I/usr/include/KF5/KI18n -I/usr/include/KF5/KCoreAddons -I/usr/include/KF5/KXmlGui -I/usr/include/x86_64-linux-gnu/qt5/QtDBus -I/usr/include/x86_64-linux-gnu/qt5/QtXml -I/usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs -I/usr/include/KF5/KConfigGui -I/usr/include/KF5/KAuth -I/usr/include/x86_64-linux-gnu/qt5/QtSql    -o CMakeFiles/digikamdatabasemain_src.dir/utils/dio.cpp.o -c "/tmp/buildd/digikam5-5.0.0~beta4/core/libs/database/utils/dio.cpp"
/tmp/buildd/digikam5-5.0.0~beta4/core/libs/database/utils/dio.cpp: In member function 'void Digikam::DIO::slotResult()':
/tmp/buildd/digikam5-5.0.0~beta4/core/libs/database/utils/dio.cpp:359:50: error: 'class QList<QString>' has no member named 'join'
         QString errors = jobThread->errorsList().join(QLatin1String("\n"));
From buildlog:
                                                  ^
core/libs/database/CMakeFiles/digikamdatabasemain_src.dir/build.make:126: recipe for target 'core/libs/database/CMakeFiles/digikamdatabasemain_src.dir/utils/dio.cpp.o' failed
make[4]: *** [core/libs/database/CMakeFiles/digikamdatabasemain_src.dir/utils/dio.cpp.o] Error 1
make[4]: Leaving directory '/tmp/buildd/digikam5-5.0.0~beta4/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:3319: recipe for target 'core/libs/database/CMakeFiles/digikamdatabasemain_src.dir/all' failed
make[3]: *** [core/libs/database/CMakeFiles/digikamdatabasemain_src.dir/all] Error 2
Comment 1 Maik Qualmann 2016-03-09 19:35:22 UTC
Git commit fee4ce3e5e0909cf0d6f0e1fadda15264d533189 by Maik Qualmann.
Committed on 09/03/2016 at 19:34.
Pushed by mqualmann into branch 'master'.

fix possible compile problem
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +2    -2    libs/database/utils/dio.cpp

http://commits.kde.org/digikam/fee4ce3e5e0909cf0d6f0e1fadda15264d533189
Comment 2 Philip Johnsson 2016-03-10 18:44:45 UTC
Looks like that commit did the trick. Beta 4 builds when I patch the tarball with it. Thanks.