Bug 360273

Summary:	In message view horizontal scroll bar appears when vertical scroll bar appears
Product:	[Applications] trojita	Reporter:	Erik Quaeghebeur <bugs.kde.org>
Component:	Desktop GUI	Assignee:	Trojita default assignee <trojita-bugs>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	NOR
Version First Reported In:	git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/trojita/3d4d89ee2e23048b43bd6d3f50ca91b20d09239e	Version Fixed In:
Sentry Crash Report:

Description Erik Quaeghebeur 2016-03-08 22:24:30 UTC

Since the new envelope design (I think), whenever a message is (vertically) too long for the window so that a vertical scroll bar appears, also a horizontal scroll bar appears. I guess this is due to the horizontal size of the vertical scroll bar not being taken into account in some width calculation somewhere.

Reproducible: Always

Steps to Reproduce:
1. look at message in some message view (wide, compact, one at a time, window)
2. manipulate window size so that content does not fit vertically

Actual Results:  
vertical scroll bar appears and horizontal scroll bar appears

Expected Results:  
vertical scroll bar appears and horizontal scroll bar does not appear

Comment 1 Thomas Lübking 2016-03-09 01:11:26 UTC

Affects Fusion & Gtk+ but not Breeze and Virtuality.
Either some frame or related to scrollbars in/out of the frame.

Comment 2 Jan Kundrát 2016-03-09 07:04:11 UTC

FYI, this is definitely not a regression due to the recent changes. I've 
been seeing this on Fusion "forever".

Comment 3 Jan Kundrát 2016-03-13 16:07:10 UTC

I don't know why exactly, but this seems to be fixed by the proposed patch at https://gerrit.vesnicky.cesnet.cz/r/660 . At least I don't see these scrollbars afterwards, but it could very well be just a side effect of something.

Comment 4 Jan Kundrát 2016-03-18 10:45:42 UTC

Git commit 3d4d89ee2e23048b43bd6d3f50ca91b20d09239e by Jan Kundrát.
Committed on 13/03/2016 at 15:47.
Pushed by gerrit into branch 'master'.

Improve MessageWidget's operation

Fix requesting of messages which haven't finished loading yet. This got
broken "somewhere during the MessageModel introduction".

Fix updates of tags -- the backstory is the same as above.

Switch to a stacked layout, so that we do not have to hide and show
widgets like monkeys, all by hand. That just isn't fun.

Change-Id: Ib8343b949a38eeb5d876198dcc3bb7c4952e8ffe

M  +143  -141  src/Gui/MessageView.cpp
M  +17   -7    src/Gui/MessageView.h

http://commits.kde.org/trojita/3d4d89ee2e23048b43bd6d3f50ca91b20d09239e