Bug 360257

Summary:	[RFE] Warn the user if dnsmasq is not installed
Product:	[Plasma] plasmashell	Reporter:	Elvis Angelaccio <elvis.angelaccio>
Component:	Networks widget	Assignee:	Jan Grulich <jgrulich>
Status:	RESOLVED UPSTREAM
Severity:	wishlist	CC:	jgrulich, lukas, nate
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Elvis Angelaccio 2016-03-08 15:54:20 UTC

If dnsmasq is not installed, plasma-nm is not able to share an ethernet connection via wi-fi. However the applet did not warn me about this, I had to look into the journactl logs in order to fix the problem.

Reproducible: Always

Steps to Reproduce:
1. Make sure dnsmasq is not installed
2. Create a "Wi-fi (shared)" connection
3. Try to connect to this new shared connection

Actual Results:  
A generic error message (which I don't remember now) pops up in a notification.

Expected Results:  
A specific error message about missing dnsmasq dependency.

Comment 1 Jan Grulich 2016-03-09 09:52:32 UTC

I don't think we should be checking this. We display the error message from NetworkManager once it fails to activate the connection and if NM is missing something, it should report it then in the error message which we display to the user. I also think that this is a packaging issue, if NM requires something then it should be as a dependency (we have that in Fedora).

Comment 2 Elvis Angelaccio 2016-03-09 10:24:37 UTC

(In reply to Jan Grulich from comment #1)
> I don't think we should be checking this. We display the error message from
> NetworkManager once it fails to activate the connection and if NM is missing
> something, it should report it then in the error message which we display to
> the user.
This makes sense indeed, so this report probably belongs upstream?

> I also think that this is a packaging issue, if NM requires
> something then it should be as a dependency (we have that in Fedora).

I was wondering the same, because the plasma-nm Arch package does not require dnsmasq as optional dependency. However I discovered later that the networkmanager package does. So the Arch packaging is probably correct.

Comment 3 Jan Grulich 2016-03-09 10:56:46 UTC

(In reply to Elvis Angelaccio from comment #2)
> (In reply to Jan Grulich from comment #1)
> > I don't think we should be checking this. We display the error message from
> > NetworkManager once it fails to activate the connection and if NM is missing
> > something, it should report it then in the error message which we display to
> > the user.
> This makes sense indeed, so this report probably belongs upstream?
Yes, if you want NM to report this error then report it to NM bugzilla.

> > I also think that this is a packaging issue, if NM requires
> > something then it should be as a dependency (we have that in Fedora).
> 
> I was wondering the same, because the plasma-nm Arch package does not
> require dnsmasq as optional dependency. However I discovered later that the
> networkmanager package does. So the Arch packaging is probably correct.
It shouldn't be as a dependency for plasma-nm package, but for NetworkManager. Looking at NM package in Archlinux I see that dnsmasq is optional dependency.

Comment 4 Elvis Angelaccio 2016-03-10 10:00:46 UTC

(In reply to Jan Grulich from comment #3)
> (In reply to Elvis Angelaccio from comment #2)
> > (In reply to Jan Grulich from comment #1)
> > > I don't think we should be checking this. We display the error message from
> > > NetworkManager once it fails to activate the connection and if NM is missing
> > > something, it should report it then in the error message which we display to
> > > the user.
> > This makes sense indeed, so this report probably belongs upstream?
> Yes, if you want NM to report this error then report it to NM bugzilla.

Done :)

https://bugzilla.gnome.org/show_bug.cgi?id=763442

Comment 5 Ben Cooksley 2024-12-23 18:25:45 UTC

Bulk transfer as requested in T17796